Page MenuHomePhabricator

Audit (and potentially remove) old Defines.php constants
Open, Needs TriagePublic

Description

The following constants have no uses, and are only referenced in core's Defines.php and operations / mediawiki-config's src/defines.php

/** @{
 * Anti-lock flags
 * Was used by $wgAntiLockFlags, which was removed with 1.25
 * Constants kept to not have warnings when used in LocalSettings
 */
define( 'ALF_PRELOAD_LINKS', 1 );
define( 'ALF_PRELOAD_EXISTENCE', 2 );
define( 'ALF_NO_LINK_LOCK', 4 );
define( 'ALF_NO_BLOCK_LOCK', 8 );

/** @{
 * Date format selectors; used in user preference storage and by
 * Language::date() and co.
 */
define( 'MW_DATE_DEFAULT', 'default' );
define( 'MW_DATE_MDY', 'mdy' );
define( 'MW_DATE_DMY', 'dmy' );
define( 'MW_DATE_YMD', 'ymd' );
define( 'MW_DATE_ISO', 'ISO 8601' );

/**
 * Hook support constants
 */
define( 'MW_SUPPORTS_LOCALISATIONCACHE', 1 );
define( 'MW_SUPPORTS_CONTENTHANDLER', 1 );
define( 'MW_EDITFILTERMERGED_SUPPORTS_API', 1 );

Is there any process for deprecating / removing these?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 697176 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Defines.php: Drop obsolete Anti-lock flags

https://gerrit.wikimedia.org/r/697176

Change 697176 merged by jenkins-bot:

[mediawiki/core@master] Defines.php: Drop obsolete Anti-lock flags

https://gerrit.wikimedia.org/r/697176