Page MenuHomePhabricator

Drop cssLint warning about IE-only errors from CodeEditor
Closed, ResolvedPublic

Description

I'm not sure if this is the right place for the task, but still. I think we should turn off this warning: The box-sizing property isn't supported in IE6 and IE7. IE7 and IE6 not supported by MediaWiki anymore: https://www.mediawiki.org/wiki/Compatibility.

Event Timeline

Aklapper renamed this task from Ignore cssLint warning about box-sizing to Ignore cssLint warning about box-sizing (because applies to IE6/IE7 only).May 24 2020, 11:07 AM

@Tgr hello, can you help me, please? :) I think we need to disable all errors of unsupported browsers who can look at this? :)

@Tgr hello, can you help me, please? :) I think we need to disable all errors of unsupported browsers who can look at this? :)

This code is currently not supported (beyond security fixes etc).

Oh, lol. Thanks :)

@Tgr hello, can you help me, please? :) I think we need to disable all errors of unsupported browsers who can look at this? :)

This code is currently not supported (beyond security fixes etc).

I'm not familiar with CodeEditor, in any case. I assume you just need to update the ACE editor that's bundled with it (and hope there have not been any backwards incompatible changes).

Iniquity renamed this task from Ignore cssLint warning about box-sizing (because applies to IE6/IE7 only) to Drop support cssLint warning about errors IE6-IE10 only.May 30 2022, 11:15 PM

Change 801194 had a related patch set uploaded (by Iniquity; author: Iniquity):

[mediawiki/extensions/CodeEditor@master] Drop support cssLint warning about errors IE6-IE10 only

https://gerrit.wikimedia.org/r/801194

I'm not familiar with CodeEditor, in any case. I assume you just need to update the ACE editor that's bundled with it (and hope there have not been any backwards incompatible changes).

Thanks for the tip! :) I created a patch.

Tgr renamed this task from Drop support cssLint warning about errors IE6-IE10 only to Drop cssLint warning about IE-only errors from CodeEditor.May 31 2022, 7:42 AM

Change 801194 abandoned by Iniquity:

[mediawiki/extensions/CodeEditor@master] Drop support cssLint warning about errors IE6-IE10 only

Reason:

Waiting for CSSlint to be replaced in Ace

https://gerrit.wikimedia.org/r/801194

Izno added a project: TemplateStyles.
Izno moved this task from Backlog to External on the TemplateStyles board.
Izno assigned this task to DLynch.
Izno subscribed.

The ones in the proposed patch were fixed by upgrading to 1.15.