Add "composer phan" type command to composer.json
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	May 24 2020, 4:50 PM

Description

Forking from T253322: Enable Phan on Chameleon Skin...

Can we add a "composer phan" command to composer.json to libraries/extensions et al that have phan setup so they can run phan without having to do vendor/bin/phan etc?

Details

Project	Branch	Lines +/-	Subject
mediawiki/core	master	+1 -1	Fix 'composer phan' command
mediawiki/core	master	+1 -0	composer.json: Add a phan script command
labs/libraryupgrader	master	+1 -0	Follow-up eac01fd: Actually run command
labs/libraryupgrader	master	+65 -0	Add `composer phan` convenience function if phan is installed

Customize query in gerrit

Related Objects

Mentioned In: rLLUP7c6c2b193f4d: Follow-up eac01fd: Actually run command
rLLUPeac01fd49d87: Add `composer phan` convenience function if phan is installed
Mentioned Here: T253322: Enable Phan on Chameleon Skin

Event Timeline

Reedy created this task.May 24 2020, 4:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2020, 4:50 PM

Reedy added a project: phan.May 24 2020, 4:50 PM

For completeness, I believe that the command should be vendor/bin/phan -d . --long-progress-bar if the version of mediawiki-phan-config is >=0.9.0, and vendor/bin/phan -d . -p otherwise.

Change 601410 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[labs/libraryupgrader@master] Add composer phan convenience function if phan is installed

https://gerrit.wikimedia.org/r/601410

gerritbot added a project: Patch-For-Review.Jun 1 2020, 8:07 PM

Jdforrester-WMF claimed this task.Jun 1 2020, 8:07 PM

Change 601410 merged by jenkins-bot:
[labs/libraryupgrader@master] Add composer phan convenience function if phan is installed

https://gerrit.wikimedia.org/r/601410

jenkins-bot mentioned this in rLLUPeac01fd49d87: Add `composer phan` convenience function if phan is installed.Jun 1 2020, 10:14 PM

Jdforrester-WMF closed this task as Resolved.Jun 1 2020, 10:17 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2020, 11:10 PM

What happened with this...

As far as I can see, only MediaWiki-extensions-OrphanedTalkPages has composer phan

Do we need to do something to get this added? And do MW core manually?

Huh, yeah, I thought this was going to work.

Jdforrester-WMF reopened this task as Open.Dec 23 2020, 1:37 AM

Change 651599 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] composer.json: Add a phan script command

https://gerrit.wikimedia.org/r/651599

gerritbot added a project: Patch-For-Review.Dec 23 2020, 1:37 AM

Change 651663 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[labs/libraryupgrader@master] Follow-up eac01fd: Actually run command

https://gerrit.wikimedia.org/r/651663

Change 651663 merged by jenkins-bot:
[labs/libraryupgrader@master] Follow-up eac01fd: Actually run command

https://gerrit.wikimedia.org/r/651663

Legoktm mentioned this in rLLUP7c6c2b193f4d: Follow-up eac01fd: Actually run command.Dec 23 2020, 1:46 AM

Jdforrester-WMF closed this task as Resolved.Dec 23 2020, 1:47 AM

Change 651599 merged by jenkins-bot:
[mediawiki/core@master] composer.json: Add a phan script command

https://gerrit.wikimedia.org/r/651599

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 23 2020, 3:09 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 23 2020, 3:10 AM

Change 651712 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] Fix 'composer phan' command

https://gerrit.wikimedia.org/r/651712

gerritbot added a project: Patch-For-Review.Dec 23 2020, 4:47 PM

Change 651712 merged by jenkins-bot:
[mediawiki/core@master] Fix 'composer phan' command