Page MenuHomePhabricator

Special:AbuseFilter/tools shown empty grey bar
Closed, ResolvedPublic

Description

...In place of the restore autopromote interface, for users that don't have access to restoring autopromote

See https://en.wikipedia.org/wiki/Special:AbuseFilter/tools

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

...In place of the restore autopromote interface, for users that don't have access to restoring autopromote

This is not correct. The grey "bar" is a <pre> element where we put the result of evaluating the filter above. This should perhaps be highlighted by the fact that it's wrapped in the same fieldset where the edit box is. Perhaps we could add a label to make this explicit, or hide it if empty.

...In place of the restore autopromote interface, for users that don't have access to restoring autopromote

This is not correct. The grey "bar" is a <pre> element where we put the result of evaluating the filter above. This should perhaps be highlighted by the fact that it's wrapped in the same fieldset where the edit box is. Perhaps we could add a label to make this explicit, or hide it if empty.

woops, sorry; that makes sense that its shown. I would opt for the label route

Change 621290 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] ViewTools: hide the result box when empty

https://gerrit.wikimedia.org/r/621290

Change 621290 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] ViewTools: hide the result box when empty

https://gerrit.wikimedia.org/r/621290