Page MenuHomePhabricator

Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page
Open, Needs TriagePublicBUG REPORT

Description

Steps to Reproduce:

  1. Create a page from an account without editor, in a namespace recognized by Flagged Revs
  2. Use the api to review that one revision from an account with reviewer:
{
    action:"review",
    revid:<revision id>
}
  1. Now the page is marked as reviewed in recent changes, you can look at verify
  2. Move the page to a namespace ignored by Flagged Revs (e.g. User)

Actual Results: The page is now marked as Unreviewed in Recent Changes

Expected Results: The page should still be reviewed in recent changes.

Event Timeline

RheingoldRiver renamed this task from Using review API on all revisions of a page doesn't review the page itself to [FlaggedRevs] Using review API on all revisions of a page doesn't review the page itself.May 25 2020, 7:37 AM

Okay so I've found a workaround for my own purposes, which is to leave behind a redirect in the move and then delete the redirect afterwards. This suppresses the "unchecked page." But it's still kind of weird:

  1. Create page - you have an unchecked page at OriginalLocation
  2. Check page - no unchecked page
  3. Move page WITH redirect - now you have a page which exists at OriginalLocation and is not unchecked, but says it's unchecked in Recent Changes
  4. Delete OriginalLocation - no unchecked page anymore

Also, actually this issue seems to exist even if you press the "Review" button on the page, it's not API-specific - I'd thought it was working from pressing the button, but actually it wasn't.

RheingoldRiver renamed this task from [FlaggedRevs] Using review API on all revisions of a page doesn't review the page itself to [FlaggedRevs] Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page.May 25 2020, 8:14 AM
Aklapper renamed this task from [FlaggedRevs] Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page to Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page.May 25 2020, 10:19 AM