Page MenuHomePhabricator
Create Task
Maniphest T253585

"All Notifications" and "Preferences" have incorrect control type
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  • Go to a page
  • Navigate till "Your Alerts" button and hit enter
  • Check "All Notifications" and "Preferences" has correct control type

Actual Results:

  • "All Notifications" and "Preferences" control type is button. Whenever a url changes on click the control type should be "hyperlink"

Expected Results:

  • "All Notifications" and "Preferences" control type should be link

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as linkmediawiki/extensions/Echomaster+2 -0
Customize query in gerrit

Event Timeline

Bkudiess-msft created this task.May 25 2020, 6:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2020, 6:38 PM
Bkudiess-msft added projects: Accessibility, Notifications (Echo).May 25 2020, 6:38 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 25 2020, 6:38 PM
gerritbot added a comment.May 25 2020, 8:15 PM

Change 598532 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[mediawiki/extensions/Echo@master] NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link

https://gerrit.wikimedia.org/r/598532

gerritbot added a project: Patch-For-Review.May 25 2020, 8:15 PM
gerritbot added a comment.Jul 13 2020, 8:47 PM

Change 598532 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link

https://gerrit.wikimedia.org/r/598532

Volker_E closed this task as Resolved.Jul 13 2020, 8:50 PM
Volker_E removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 13 2020, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits