Page MenuHomePhabricator

"All Notifications" and "Preferences" have incorrect control type
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  • Go to a page
  • Navigate till "Your Alerts" button and hit enter
  • Check "All Notifications" and "Preferences" has correct control type

Actual Results:

  • "All Notifications" and "Preferences" control type is button. Whenever a url changes on click the control type should be "hyperlink"

Expected Results:

  • "All Notifications" and "Preferences" control type should be link

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2020, 6:38 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 25 2020, 6:38 PM

Change 598532 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[mediawiki/extensions/Echo@master] NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link

https://gerrit.wikimedia.org/r/598532

Change 598532 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link

https://gerrit.wikimedia.org/r/598532

Volker_E closed this task as Resolved.Jul 13 2020, 8:50 PM
Volker_E removed a project: Patch-For-Review.