Page MenuHomePhabricator

extensions including semantic-forms via composer are broken and breaking extension distributor
Open, Needs TriagePublic

Description

Split from T215713

Page-forms seems to have some issue. When extdist tries to download them, it pauses waiting for private package credentials. this breaks things. It will break the script anytime someone commits to one of these repos.

Repos affected: https://codesearch.wmflabs.org/search/?q=mediawiki%2Fpage-forms&i=nope&files=&repos=

Event Timeline

Bawolff created this task.May 25 2020, 7:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2020, 7:02 PM
Bawolff added a comment.EditedMay 25 2020, 7:21 PM

At least one of the problematic extensions is SemanticPageSeries and SemanticImageInput

Actual output looks like:

HEAD is now at 08605a5... Localisation updates from https://translatewiki.net.
Updating dependencies
Package operations: 27 installs, 0 updates, 0 removals
  - Installing composer/installers (v1.9.0): Loading from cache
  - Installing mediawiki/semantic-forms (3.7): Downloading (failed)    Failed to download mediawiki/semantic-forms from dist: The "https://api.github.com/repos/wikimedia/mediawiki-extensions-SemanticForms/zipball/7e9e627853dea94d6b1344383513927fd037903b" file could not be downloaded (HTTP/1.1 404 Not Found)
    Now trying to download from source
  - Installing mediawiki/semantic-forms (3.7): The authenticity of host 'github.com (140.82.114.4)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? yes
Cloning failed using an ssh key for authentication, enter your GitHub credentials to access private repos
Head to https://github.com/settings/tokens/new?scopes=repo&description=Composer+on+extdist-04+2020-05-25+1834
to retrieve a token. It will be stored in "/home/extdist/.composer/auth.json" for future use by Composer.
Token (hidden): 
Invalid token provided.
You can also add it manually later by using "composer config --global --auth github-oauth.github.com <token>"
Cloning 7e9e627853

                                                                                                                     
  [RuntimeException]                                                                                                 
  Failed to execute git clone --no-checkout 'https://no:***@github.com/wikimedia/mediawiki-extensions-SemanticForms  
  .git.git' 'extensions/SemanticForms/' && cd 'extensions/SemanticForms/' && git remote add composer 'https://no:**  
  *@github.com/wikimedia/mediawiki-extensions-SemanticForms.git.git' && git fetch composer && git remote set-url or  
  igin 'https://github.com/wikimedia/mediawiki-extensions-SemanticForms.git.git' && git remote set-url composer 'ht  
  tps://github.com/wikimedia/mediawiki-extensions-SemanticForms.git.git'                                             
                                                                                                                     
  Cloning into 'extensions/SemanticForms'...                                                                         
  remote: Invalid username or password.                                                                              
  fatal:***@github.com/wikimedia/mediawiki-extensions-SemanticForms.git.git/'

Maybe part of the issue is that old REL1_30, etc branches are still using old dependency name.

This might be less of an issue in practise, because except when force rebuilding like i did just now, this code path will only be execute if someone commits to the branch in question.

Maybe part of the issue is that old REL1_30, etc branches are still using old dependency name.

extdist should only be building for REL1_31 and above...