Page MenuHomePhabricator

Tabs may not be valid YAML
Closed, ResolvedPublic

Description

Problem
Using YAML's "Block Style" a tab is not a valid indention character:
https://yaml.org/spec/1.2/spec.html#id2777534

Proposed Solution
The .editorconfig should be updated to change the indent_style to space rather than tab for *.yml/*.yaml so a developer's IDE is property configured to use spaces in these files rather than tabs.

Event Timeline

The .editorconfig should be updated to change the indent_style to space rather than tabs so a developer's IDE is property configured to use spaces in these files rather than tabs.

I presume you actually mean

The .editorconfig should be updated to change the indent_style to space rather than tabs for *.yml/*.yaml so a developer's IDE is property configured to use spaces in these files rather than tabs.

As we use tabs for PHP and JS

Change 598540 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Set .editorconfig to use spaces instead of tabs on YAML files

https://gerrit.wikimedia.org/r/598540

I presume you actually mean

The .editorconfig should be updated to change the indent_style to space rather than tabs for *.yml/*.yaml so a developer's IDE is property configured to use spaces in these files rather than tabs.

As we use tabs for PHP and JS

Yes, that is exactly what I meant. Apologies for the confusion. It should be correct in the patch. :)

Change 598540 merged by jenkins-bot:
[mediawiki/core@master] Set .editorconfig to use spaces instead of tabs on YAML files

https://gerrit.wikimedia.org/r/598540

dbarratt claimed this task.