LowerCamelFunctionsNameSniff should allow serialize and unserialize magic methods for PHP 7.4
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	May 26 2020, 2:08 PM

Project Tags

Referenced Files

None

Subscribers

Addshore

Aklapper

Description

These 2 new methods can be seen added in https://wiki.php.net/rfc/custom_object_serialization
I hit into this while reviewing this PR https://github.com/wmde/WikibaseDataModel/pull/824 for T243590

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	LowerCamelFunctionsNameSniff, add __serialize and __unserialize	Addshore	mediawiki/tools/codesniffer	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T253624: Evaluate the future of wikibase-codesniffer
T253636: Use mediawiki-codesniffer 31.0.0 in WikibaseDatamodel when released
Mentioned Here: T243590: Fix WikibaseDataModel CI for php 7.4

Event Timeline

Addshore created this task.May 26 2020, 2:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2020, 2:08 PM

Addshore claimed this task.May 26 2020, 2:08 PM

Restricted Application added a project: User-Addshore. · View Herald TranscriptMay 26 2020, 2:08 PM

Change 598745 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/tools/codesniffer@master] LowerCamelFunctionsNameSniff, add serialize and unserialize

https://gerrit.wikimedia.org/r/598745

gerritbot added a project: Patch-For-Review.May 26 2020, 2:10 PM

Addshore added a project: PHP 7.4 support.May 26 2020, 2:12 PM

Addshore mentioned this in T253636: Use mediawiki-codesniffer 31.0.0 in WikibaseDatamodel when released.May 26 2020, 2:16 PM

Addshore mentioned this in T253624: Evaluate the future of wikibase-codesniffer.May 26 2020, 2:20 PM

Change 598745 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] LowerCamelFunctionsNameSniff, add serialize and unserialize