Page MenuHomePhabricator

LowerCamelFunctionsNameSniff should allow __serialize and __unserialize magic methods for PHP 7.4
Closed, ResolvedPublic

Description

These 2 new methods can be seen added in https://wiki.php.net/rfc/custom_object_serialization
I hit into this while reviewing this PR https://github.com/wmde/WikibaseDataModel/pull/824 for T243590

Event Timeline

Addshore created this task.May 26 2020, 2:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2020, 2:08 PM
Addshore claimed this task.May 26 2020, 2:08 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptMay 26 2020, 2:08 PM

Change 598745 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/tools/codesniffer@master] LowerCamelFunctionsNameSniff, add serialize and unserialize

https://gerrit.wikimedia.org/r/598745

Change 598745 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] LowerCamelFunctionsNameSniff, add serialize and unserialize

https://gerrit.wikimedia.org/r/598745

Umherirrender closed this task as Resolved.May 26 2020, 7:38 PM