Page MenuHomePhabricator

Convert WikimediaEvents to use ResourceLoader packageFiles
Closed, ResolvedPublic

Description

Work has already been started by @SBisson at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/553356. modules files have been moved around since then so this will be difficult to rebase. We should just start a new patch.

Motivation
To recover the cost of the legacy solution at https://gerrit.wikimedia.org/r/576145.

Event Timeline

This will also allow us to finish https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/576145, where we don't use the deprecated onResourceLoaderGetConfigVars

@Krinkle WikimediaEvents uses skinScripts, but the packageFiles docs say this isn't supported (yet). How to resolve?

(I don't really know what skinScripts is...)

@SBisson, do you think you could finish this patch? I think you have a lot more context here as to how WikimediaEvents is used.

For skinScripts this is no longer an issue. The path of the package file can be defined by a callback and thus vary by the given skin name (in $context) the same skinScripts did.

Oh, I guess the docs should be updated then?

Milimetric moved this task from Incoming to Event Platform on the Analytics board.

Change 553356 had a related patch set uploaded (by Krinkle; owner: Sbisson):
[mediawiki/extensions/WikimediaEvents@master] Convert modules to use packageFiles

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/ /553356

LGoto moved this task from Inbox to QA/Review on the Better Use Of Data board.

@Jdlrobson @phuedx FYI this is riding the next train branch, might be worth some testing attention just in case.

Change 553356 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Convert modules to use packageFiles

https://gerrit.wikimedia.org/r/553356

Excellent! I'd asked @Mholloway if he was looking for a merger just the other day. Great work, everyone!

Mholloway moved this task from QA/Review to Sign-off on the Better Use Of Data board.

Change 677840 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikimediaEvents@master] desktopWebUIActionsTracking: Fetch config value correctly

https://gerrit.wikimedia.org/r/677840

Change 677840 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] desktopWebUIActionsTracking: Fetch config value correctly

https://gerrit.wikimedia.org/r/677840