Page MenuHomePhabricator

Screen reader is announcing VectorMenu dropdown as checkbox
Open, MediumPublicBUG REPORT

Description

Steps to Reproduce:
  • Go to a wiki page
  • Turn on your screen reader of preference
  • Navigate to "Move" and hit enter
Actual Results:
  • The screen reader reads the "Move" button as checkbox
Expected Results:
  • Screen reader announce as button and aria-expanded status
Related:

T246420: Limit content width, and refine alignment & styling of relevant elements
T243126: Investigate accessibility of checkbox hacks

Checkbox hidden in: 607311/checkboxHack.less

Related Objects

StatusSubtypeAssignedTask
ResolvedGoalovasileva
ResolvedJdlrobson
Resolvedovasileva
ResolvedSpikeovasileva
ResolvedSpikephuedx
Resolvedovasileva
ResolvedSpikeVolker_E
OpenNone
OpenBUG REPORTBkudiess-msft
ResolvedSpikeovasileva
Resolvedovasileva
ResolvedBUG REPORTmatmarex
Resolvedovasileva
ResolvedJdlrobson
Resolvedphuedx
Resolvednray
ResolvedMayakp.wiki
ResolvedMayakp.wiki
Stalledovasileva
OpenNone
ResolvedEdtadros
OpenNone
OpenNone

Event Timeline

See role=button discussion on checkbox hack in T243126. We will all live in a better world very soon!
Keeping this task open as it is good to have it filed under Vector as well.

Change 598801 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[mediawiki/skins/Vector@master] Fixes screen reader announcing dropdown menu as chackbox

https://gerrit.wikimedia.org/r/598801

ovasileva triaged this task as Medium priority.Jun 1 2020, 8:52 AM

Moving to backlog given this is stalled on T243126. We should pull that one in if we want to move this along.

Demian changed the task status from Stalled to Open.Jul 6 2020, 2:56 AM

@Bkudiess-msft: Recent changes in T246420 made the checkbox hidden and the button react to events:
https://github.com/wikimedia/Vector/blob/bfc95effdbcac20ebbd30a03c9bdbc5ef8b6fbdc/resources/skins.vector.styles/checkboxHack.less#L39

Could you check how this setup fares in your screen reader?

@Demian Do you have this deployed somewhere for testing?

Yes, the above commit is from the master branch which is continuously deployed to BETA.

@Demian Tested with windows narrator, screen reader is announcing the correct text (expanded or collapsed) instead of announcing it as checkbox. But now I'm not able to interact with this button hack using only the keyboard, only works with a mouse click. This is reproable without a screen reader as well.

Thanks for the test!

But now I'm not able to interact with this button hack using only the keyboard, only works with a mouse click.

I've been working hard on that for the best part of the weekend: T257075: Simplify the checkboxHack API
Team will discuss it today. I tried to make a patchdemo for it, but the long list of patches somehow confused the system, that I have yet to resolve.

@Demian But now I'm not able to interact with this button hack using only the keyboard, only works with a mouse click.

The DEMO is ready: http://patchdemo.wmflabs.org/wikis/cedef736804997e570ad35c605f6322b/w/