Page MenuHomePhabricator

WikimediaDebug "Find in XHGui" can't find profiles
Closed, ResolvedPublic

Description

  1. Navigate to https://aa.wikipedia.org/wiki/Special:Blankpage
  2. Enable WikmediaDebug, pick a server, tick the XHGui box.
  3. Reload.
  4. Click "Find in XHGui" link.

The link points to XHGui with the request ID from mw.config.get('wgRequestId') but the profile is stored under a different ID.

Event Timeline

This is fall out from changes in prod (possibly around ATS). The wmf-config/profiler.php code uses UNIQUE_ID set by Apache for the profile's req ID.

In MediaWiki, however, this is no longer used in WMF prod, because there is another ID given to web requsets (as X-Request-ID) which has predence in MW. This was enabled sometime in the last few months I think.

We ran into the same issue with Logstash (T247786, T201409), which was fixed in https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/582948/.

Change 598825 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[operations/mediawiki-config@master] profiler: Use X-Request-Id instead of UNIQUE_ID for XHGui

https://gerrit.wikimedia.org/r/598825

Krinkle triaged this task as High priority.
Krinkle moved this task from Inbox to Doing (old) on the Performance-Team board.

Change 598825 merged by jenkins-bot:
[operations/mediawiki-config@master] profiler: Use X-Request-Id instead of UNIQUE_ID for XHGui

https://gerrit.wikimedia.org/r/598825

Mentioned in SAL (#wikimedia-operations) [2020-05-26T21:18:44Z] <krinkle@deploy1001> Synchronized wmf-config/profiler.php: Ib0bf8d97b10b, T253674 (duration: 01m 06s)