Dedicated Flamegraphs for save timing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	May 26 2020, 8:01 PM

Description

Create forward and reverse flamegraphs for calls to SubmitAction::show.

See T247717

Details

	Subject	Repo	Branch	Lines +/-
	arclamp: add svgs for some key entrypoint/singleton methods calls	operations/puppet	production	+110 -27
	arclamp: add svgs for some key entrypoint/singleton methods calls	performance/arc-lamp	master	+111 -28

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T255502 Goal: Save Timing median back under 1 second
		Resolved		aaron	T253679 Dedicated Flamegraphs for save timing

Event Timeline

aaron created this task.May 26 2020, 8:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2020, 8:01 PM

aaron mentioned this in T247717: Reduce flamegraph.pl threshold from minwidth=2 to minwidth=1.May 26 2020, 8:01 PM

Krinkle added a project: Arc-Lamp.Jun 2 2020, 8:15 PM

• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Jun 2 2020, 8:16 PM

Krinkle triaged this task as Medium priority.Jun 15 2020, 9:42 PM

Krinkle added a parent task: T255502: Goal: Save Timing median back under 1 second.

Krinkle moved this task from Doing (old) to To-do: Goals, prioritized next 4 Quarters on the Performance-Team board.

Change 598292 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[operations/puppet@production] arclamp: add svgs for some key entrypoint/singleton methods calls

https://gerrit.wikimedia.org/r/598292

gerritbot added a project: Patch-For-Review.Jun 22 2020, 6:05 PM

In T253679#6245668, @gerritbot wrote:

Change 598292 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[operations/puppet@production] arclamp: add svgs for some key entrypoint/singleton methods calls

https://gerrit.wikimedia.org/r/598292

@aaron estimates in the commit message for the above that this will add the following daily:

EditAction::show (87KB SVG uncompressed)
MediaWiki::doPreOutputCommit (34KB SVG uncompressed)
MediaWiki::doPostOutputShutdown (31KB SVG uncompressed)

Based on https://gerrit.wikimedia.org/r/597839 we are currently using 226G/250G on webperf1002. The above would add ~ 0.2M per day, with at the 45 day retention we have currently would not add even 0.1GB so, we're all good there.

aaron moved this task from To-do: Goals, prioritized next 4 Quarters to To-do: Goals prioritized current Quarter on the Performance-Team board.Jun 22 2020, 8:24 PM

Change 611465 had a related patch set uploaded (by Dave Pifke; owner: Aaron Schulz):
[performance/arc-lamp@master] arclamp: add svgs for some key entrypoint/singleton methods calls

https://gerrit.wikimedia.org/r/611465

Change 611465 merged by jenkins-bot:
[performance/arc-lamp@master] arclamp: add svgs for some key entrypoint/singleton methods calls

https://gerrit.wikimedia.org/r/611465

Krinkle closed this task as Resolved.Jul 27 2020, 8:22 PM

• dpifke mentioned this in T259167: Truncated ArcLamp output files.Jul 29 2020, 5:42 PM

Change 598292 abandoned by Legoktm:

[operations/puppet@production] arclamp: add svgs for some key entrypoint/singleton methods calls

Reason:

No longer needed, per Krinkle

https://gerrit.wikimedia.org/r/598292

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2021, 8:10 PM