Page MenuHomePhabricator

MachineVision should use the SidebarBeforeOutput hook
Closed, ResolvedPublic

Description

The MachineVision extension uses the BaseTemplateToolbox hook to add a link to the sidebar.

The SIdebarBeforeOutput hook now includes the toolbox a so can be used to add to this array and extensions should use that hook instead, per the deprecation plan of BaseTemplateToolbox (T253416).

Event Timeline

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptMay 26 2020, 8:24 PM

Change 600218 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/MachineVision@master] Use SidebarBeforeOutput hook to add sidebar link

https://gerrit.wikimedia.org/r/600218

Change 600218 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Use SidebarBeforeOutput hook to add sidebar link

https://gerrit.wikimedia.org/r/600218

Thanks @egardner can i resolve this or do you want to QA as part of your team process?

This is simple enough to just go ahead and close.

Reedy renamed this task from MachineVision should use the SidebarBeforeOutput hook to MachineVision should use the SidebarBeforeOutput hook .Jun 1 2020, 11:17 PM
Jdlrobson closed this task as Resolved.Jun 1 2020, 11:19 PM
Jdlrobson claimed this task.