Page MenuHomePhabricator
Create Task
Maniphest T253686

PerformanceInspector should use SidebarBeforeOutput hook
Closed, DeclinedPublic
Actions

Description

The BaseTemplateToolbox hook is being deprecated (T253416).

The SIdebarBeforeOutput hook now includes the toolbox so that hook can be used to add to this array instead

Related Objects

Event Timeline

Jdlrobson created this task.May 26 2020, 8:27 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptMay 26 2020, 8:27 PM
• Gilles added subscribers: Peter, • Gilles.May 28 2020, 9:12 AM

@Peter what do you want to do with this? Address this deprecation problem or retire PerformanceInspector altogether?

Jdlrobson added a comment.Jun 1 2020, 11:20 PM

@Gilles @Peter let me know your preference. I'm happy to provide a patch if that makes the decision easier :)

• Gilles added a comment.Jun 2 2020, 3:44 AM

I can definitely review a patch.

Krinkle subscribed.Jun 2 2020, 4:18 PM

The extension was only ever on Beta, but is currently not deployed anywhere. It is effectively like any other not-WMF-prod extension hosted in Gerrit now, so this probably does not need to block the parent task which requires core and WMF prod to be updated before we deprecate.

Jdlrobson removed a parent task: T253416: Deprecate BaseTemplateToolbox hook.Jun 2 2020, 5:36 PM
Jdlrobson awarded a token.Jun 2 2020, 5:40 PM
Krinkle removed a project: Vector 2022.Jun 2 2020, 8:12 PM
• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Jun 2 2020, 8:13 PM
Krinkle edited projects, added: Performance-Team (Radar); removed: MediaWiki-extensions-PerformanceInspector, Performance-Team.Apr 27 2021, 10:08 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
Krinkle edited projects, added: MediaWiki-extensions-PerformanceInspector; removed: Performance-Team (Radar).
Krinkle closed this task as Declined.Jul 28 2021, 11:14 PM
Jdlrobson added a comment.Jul 28 2021, 11:16 PM

Does this mean the extension is going to be decommissioned.archived? At minimum it would be great if this didn't show up in a code search.

Jdlrobson mentioned this in T256509: Remove BaseTemplateToolbox hook.Aug 15 2021, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits