Page MenuHomePhabricator

DIP bug with sidebar menu overlapping itself
Closed, DuplicatePublic

Description

Testwiki (e.g. https://test.wikipedia.org/wiki/Example?useskinversion=2) and officewiki have a display bug, causing the sidebar menu to overlap with itself, in the new modern mode of DIP.

Jon notes it is related to .vectorMenu-default and was introduced with https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/595001/4/resources/skins.vector.styles/Menu.less and missed taking https://gerrit.wikimedia.org/r/589395 into account.

Sign off steps

  • Wait for fix to roll out (circa 2nd June)
  • Remove the hack from office wiki

Event Timeline

I'm not quite sure how this slipped through QA but the issue here is that https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/595001/4/resources/skins.vector.styles/Menu.less reintroduced a class vector-menu which was in the process of being removed. Some rules for legacy Vector are queued up for removal in the next release - https://gerrit.wikimedia.org/r/589395.

I tried to find a graceful fix to this, but I can't find one that doesn't risk breaking cached pages in our other wikis. I thus suggest we patch MediaWiki:Common.css and allow this to magically fix itself ime with twhen the next release rolls out:

#p-personal ul {
    padding-left: 10em;
}

.vector-menu:not(#p-personal) ul {
    padding-left: unset;
}

.vector-menu-dropdown li,
.vector-menu-tabs:not(#p-personal) li {
    font-size: inherit;
}

.vector-menu:not(#p-personal) {
    position: unset;
}

.vector-menu:not(#p-personal):not(.vector-menu-tabs) li {
   float: unset;
}

#p-lang,
#p-cactions {
    position: relative !important;
    top: unset;
    right: unset;
}

.portal h3 {
    display: block !important;
}

BLocked on next release (which has the fix). Patched on office wiki.