Page MenuHomePhabricator

Call to a member function getUser() on boolean ( CoreParserFunctions::revisionuser ?)
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.35.0-wmf.34

message
Call to a member function getUser() on boolean

Impact

Fatal error page being shown when browsing https://www.mediawiki.org/wiki/Help_talk:Magic_words

Apparently no other pages affected so far.

Notes

Previously occurred at T251952: CoreParserFunctions::revisionuser: Call to a member function getUser() on boolean with the same page and stack trace

Details

Request ID
44e11f22-4604-490a-8d9a-da6278dce454
Request URL
https://www.mediawiki.org/wiki/Help_talk:Magic_words
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3317): CoreParserFunctions::revisionuser(Parser, string)
#1 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3021): Parser->callParserFunction(PPFrame_Hash, string, array)
#2 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPFrame_Hash)
#3 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(2862): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#4 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(1548): Parser->replaceVariables(string)
#5 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(635): Parser->internalParse(string)
#6 /srv/mediawiki/php-1.35.0-wmf.34/includes/content/WikitextContent.php(368): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#7 /srv/mediawiki/php-1.35.0-wmf.34/includes/content/AbstractContent.php(565): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#8 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RenderedRevision.php(267): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#9 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RenderedRevision.php(236): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#10 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#11 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#12 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#13 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RenderedRevision.php(198): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#14 /srv/mediawiki/php-1.35.0-wmf.34/includes/poolcounter/PoolWorkArticleView.php(204): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#15 /srv/mediawiki/php-1.35.0-wmf.34/includes/poolcounter/PoolCounterWork.php(128): PoolWorkArticleView->doWork()
#16 /srv/mediawiki/php-1.35.0-wmf.34/includes/page/Article.php(806): PoolCounterWork->execute()
#17 /srv/mediawiki/php-1.35.0-wmf.34/includes/actions/ViewAction.php(74): Article->view()
#18 /srv/mediawiki/php-1.35.0-wmf.34/includes/MediaWiki.php(519): ViewAction->show()
#19 /srv/mediawiki/php-1.35.0-wmf.34/includes/MediaWiki.php(305): MediaWiki->performAction(Article, Title)
#20 /srv/mediawiki/php-1.35.0-wmf.34/includes/MediaWiki.php(978): MediaWiki->performRequest()
#21 /srv/mediawiki/php-1.35.0-wmf.34/includes/MediaWiki.php(535): MediaWiki->main()
#22 /srv/mediawiki/php-1.35.0-wmf.34/index.php(47): MediaWiki->run()
#23 /srv/mediawiki/w/index.php(3): require(string)
#24 {main}

Event Timeline

hashar created this task.May 27 2020, 8:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2020, 8:03 AM
hashar triaged this task as Unbreak Now! priority.May 27 2020, 8:03 AM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 27 2020, 8:03 AM

Change 598960 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Partially revert "Fix impedance mismatch with Parser::getRevisionRecordObject()"

https://gerrit.wikimedia.org/r/598960

Indeed, T251952 has exactly the same stacktrace - thanks for finding that.

DannyS712 updated the task description. (Show Details)
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 27 2020, 8:13 AM

Change 599071 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Fix impedance mismatch with Parser::fetchCurrentRevisionRecordOfTitle

https://gerrit.wikimedia.org/r/599071

This is the last remaining blocker for the train, currently. @cscott: what's the best course of action on this one? Nobody else seems confident about what we should do here.

Change 598960 merged by jenkins-bot:
[mediawiki/core@master] Partially revert "Fix impedance mismatch with Parser::getRevisionRecordObject()"

https://gerrit.wikimedia.org/r/598960

Change 599071 merged by jenkins-bot:
[mediawiki/core@master] Fix impedance mismatch with Parser::fetchCurrentRevisionRecordOfTitle

https://gerrit.wikimedia.org/r/599071

Change 599104 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.34] Partially revert "Fix impedance mismatch with Parser::getRevisionRecordObject()"

https://gerrit.wikimedia.org/r/599104

Change 599104 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.34] Partially revert "Fix impedance mismatch with Parser::getRevisionRecordObject()"

https://gerrit.wikimedia.org/r/599104

Mentioned in SAL (#wikimedia-operations) [2020-05-27T19:46:25Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.34/includes/parser/CoreParserFunctions.php: T253725 Partially revert 'Fix impedance mismatch with Parser::getRevisionRecordObject()' (duration: 01m 05s)

Jdforrester-WMF closed this task as Resolved.May 27 2020, 7:51 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Fix deployed.