TimelineRowFormatter uses a custom signature for the msg method
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	dbarratt
	May 27 2020, 3:03 PM

Description

Problem
As @DannyS712 pointed out the TimelineRowFormatter uses a custom signature for the msg method.

Proposed Solution
TimelineRowFormatter could implement MessageLocalizer interface which would make the msg method consistent with other places it is found in MediaWiki.

Details

	Subject	Repo	Branch	Lines +/-
	TimelineRowFormatter::msg implement MessageLocalizer	mediawiki/extensions/CheckUser	master	+16 -5

Customize query in gerrit

Event Timeline

dbarratt created this task.May 27 2020, 3:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2020, 3:03 PM

The current msg method is private, the interface calls for public, so that would need to be changed.
That being said, since a context is available, I would suggest just using $this->context->msg() directly, and removing TimelineRowFormatter::msg entirely

In T253760#6169339, @DannyS712 wrote:

I would suggest just using $this->context->msg() directly, and removing TimelineRowFormatter::msg entirely

That makes more sense to me! :)

Will do after https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/596056/ merges to avoid conflicts

Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 27 2020, 3:46 PM

DannyS712 moved this task from Unsorted to Later on the User-DannyS712 board.May 27 2020, 3:46 PM

• Niharika moved this task from Untriaged to Tracking work by others on the Anti-Harassment board.May 28 2020, 7:09 PM

Change 636527 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CheckUser@master] TimelineRowFormatter::msg implement MessageLocalizer

https://gerrit.wikimedia.org/r/636527

gerritbot added a project: Patch-For-Review.Oct 27 2020, 2:59 AM