Page MenuHomePhabricator

mobile-html: consolidate and rename CSS colors
Closed, ResolvedPublic

Description

Background information

As part of the transition to LESS, color naming was left as a future TODO due to additional clarification needed

What

Coordinate with @schoenbaechler and @cmadeo to define color names and consolidate similar colors

Acceptance criteria

  • Color names are defined and are updated in the CSS

Proposed color names

Utilize the style guide as the base definitions, then add

Accent70 - #6699FF - formerly Stratosphere

DarkBase05 - #101418 - formerly Pitch Black
DarkBase10 - #27292D - formerly Exosphere
DarkBase20 - #2E3136 - formerly Thermosphere
DarkBase30 - #43464A - formerly Mesosphere
DarkBase90 - #E8E9EB - formerly LightBlueGray

SepiaBase85- #E1DAD1 - formerly Amate
SepiaBase90- #F0E6D6 - formerly Papyrus
SepiaBase100- #F8F1E3 - formerly Parchment

SepiaBorder- #E8DCCA - formerly Sand

SepiaGray40- #646059 - formerly Masi
SepiaGray80- #CBC8C1 - formerly Kraft

Event Timeline

Looks good to me! Much easier than the former names!
Thanks!

+1 → added a todo to also update the names on the Android theme guidelines page. Thx @JoeWalsh...

In the transition to using LESS and the Wikimedia Base UI library, most colors in-use in the application were able to be translated directly to existing variables. A couple were not directly translated, and were instead changed to similar existing variables rather than maintain one-off colors. Here is that list:

CollapseTable.less
    116 #222 -> base10 (202122) (1.01:1)
    192 #222 -> base10 (202122) (1.01:1)

EditTransform.less
    132 #eee -> base80 (eaecf0) (1.01:1)
    153 #777d84 -> base30 (72777d) (1.08:1)

FooterContainer.less
    36 #222 -> base10 (202122) (1.01:1)
    67 #222 -> base10 (202122) (1.01:1)

FooterMenu.less
    25 #222 -> base10 (202122) (1.01:1)

FooterReadMore.less
    21 #222 -> base10 (202122) (1.01:1)

ThemeTransform.less
    19 #222 -> base10 (202122) (1.01:1)
    91 #222 -> base10 (202122) (1.01:1)
    102 #222 -> base10 (202122) (1.01:1)
    123 #222 -> base10 (202122) (1.01:1)
    155 #ccc -> base70 (c8ccd1) (1:1)
    196 #ccc -> base70 (c8ccd1) (1:1)

WidenImage.less
    31 768px -> width-breakpoint-tablet (720px)