WIP: Factor convertNamespace and convertTitle methods out of LanguageConverter
Closed, InvalidPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Peter.ovchyn
	May 28 2020, 11:00 AM

Description

Story

When I design LanguageConverter I want to factor Factor convertNamespace and convertTitle methods out, so that LanguageConverter stops depending on Language

Context

The main purpose of LanguageConverter is to convert a string into string in other variant.

Function LanguageConverter::convertNamespace and LanguageConverter::convertTile adds specific functionality and have other responsibility. Moreover, they introduce an unwanted dependency between LanguageConverter and Language.

Expected Result

New service (name to be defined on review) should be introduced
Functions LanguageConverter::convertNamespace and LanguageConverter::convertTile should be moved there
Service should be covered by tests

Details

	Subject	Repo	Branch	Lines +/-
	language: introduce ConverterHelper service with ::convertNamespace and ::convertTitle	mediawiki/core	master	+485 -30

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	roman-stolar	T226832 Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends
Resolved	Peter.ovchyn	T226833 Introduce LanguageConverterFactory service
Open	roman-stolar	T243325 Avoid mutual dependency between LanguageConverter and Language by introducing specialised interfaces
Invalid	Peter.ovchyn	T253849 WIP: Factor convertNamespace and convertTitle methods out of LanguageConverter

Event Timeline

Peter.ovchyn created this task.May 28 2020, 11:00 AM

Peter.ovchyn mentioned this in T243325: Avoid mutual dependency between LanguageConverter and Language by introducing specialised interfaces.May 28 2020, 11:37 AM

Helga_sf triaged this task as High priority.May 28 2020, 12:04 PM

Helga_sf moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.

Peter.ovchyn updated the task description. (Show Details)May 28 2020, 12:08 PM

Peter.ovchyn set the point value for this task to 8.May 28 2020, 12:11 PM

Peter.ovchyn claimed this task.May 28 2020, 12:14 PM

Helga_sf moved this task from Estimated/Estimation to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.May 28 2020, 12:16 PM

Peter.ovchyn moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Jun 1 2020, 8:22 AM

Peter.ovchyn updated the task description. (Show Details)Jun 1 2020, 8:31 AM

Peter.ovchyn moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Jun 1 2020, 1:21 PM

Peter.ovchyn added a project: Patch-For-Review.

Change 601352 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] WIP! language: introduce ConverterHelper service with ::convertNamespace and ::convertTitle

https://gerrit.wikimedia.org/r/601352

Peter.ovchyn mentioned this in T254267: WIP: Replace LanguageConverter ::convertTitle and ::convertNamespace in favour of ConverterHelper's and deprecate.Jun 2 2020, 5:47 PM

Helga_sf renamed this task from Factor convertNamespace and convertTitle methods out of LanguageConverter to WIP: Factor convertNamespace and convertTitle methods out of LanguageConverter.Jun 11 2020, 11:23 AM

Helga_sf moved this task from In Progress/In Review to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.

Closed due irrelevance. The new approach is in the task: https://phabricator.wikimedia.org/T256975

Change 601352 abandoned by Peter.ovchyn:
[mediawiki/core@master] language: introduce ConverterHelper service with ::convertNamespace and ::convertTitle

Reason:

https://gerrit.wikimedia.org/r/601352

Winston_Sung removed a project: Patch-For-Review.Dec 27 2023, 5:13 PM

Winston_Sung moved this task from Backlog to Core on the MediaWiki-Language-converter board.Dec 27 2023, 5:33 PM

WIP: Factor convertNamespace and convertTitle methods out of LanguageConverterClosed, InvalidPublic8 Estimated Story PointsActions