Page MenuHomePhabricator
Create Task
Maniphest T253866

ThankYou screen text running wider than modal
Closed, ResolvedPublicBUG REPORT
Actions

Description

Environment
Browser: IE11

Expected Behavior
Should probably wrap within in available width.

VirtualBox_IE11 - Win7_28_05_2020_15_50_46.png (979×1 px, 116 KB)

Details

SubjectRepoBranchLines +/-
bridge: fix text width in ThankYou screenmediawiki/extensions/Wikibasemaster+6 -1
Customize query in gerrit

Related Objects

Event Timeline

• Pablo-WMDE created this task.May 28 2020, 1:52 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 28 2020, 1:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Pablo-WMDE added a subscriber: Lydia_Pintscher.May 29 2020, 9:27 AM

@Lydia_Pintscher Feels weird to poke you about this as an individual but there does not seem to be an intake process I trust - I guess we should have one given the product will soon be in production. Triage please.

Lydia_Pintscher triaged this task as Medium priority.May 31 2020, 9:09 AM
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Bridge board.

Uh yeah that doesn't look right :D
Setting to medium because it is in a very central place of the default workflow but only seems to be happening in some browsers.

Lucas_Werkmeister_WMDE claimed this task.Jun 5 2020, 3:49 PM
Lucas_Werkmeister_WMDE added a comment.Jun 5 2020, 3:56 PM

I think this needs a similar fix as for ReportIssue in this commit. At least, the max-width seems to fix the issue in IE11.

gerritbot added a comment.Jun 5 2020, 3:57 PM

Change 602725 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: fix text with in ThankYou screen

https://gerrit.wikimedia.org/r/602725

gerritbot added a project: Patch-For-Review.Jun 5 2020, 3:57 PM
Lydia_Pintscher added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 6 2020, 4:15 PM
Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jun 6 2020, 5:15 PM
• Pablo-WMDE mentioned this in T254733: ErrorUnknow message running wider than modal.Jun 8 2020, 10:21 AM
gerritbot added a comment.Jun 9 2020, 12:54 PM

Change 602725 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: fix text width in ThankYou screen

https://gerrit.wikimedia.org/r/602725

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 9 2020, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 1:10 PM
Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 11 2020, 8:49 AM
Lydia_Pintscher closed this task as Resolved.Jun 16 2020, 4:19 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits