Page MenuHomePhabricator

Add tags to the import if triggered by the AbuseFilter
Open, Needs TriagePublic


Note: This might be already happening auto-magically. So make sure it does not before you implement anything here.

The FileImporter currently does not respect AbuseFilter rules that add specific tags. Probably it just makes sense to add these tags if they are triggered by a rule that affects the latest revision of the file being imported. Assuming this the plan for the implementation would be roughly:

After the user submitted the form to start the import

  • Detect and collect tags triggered by rules when validating the latest revision ( including edits done by the user in the interface )
  • Add the tags to the latest revision containing content ( not the NullRevison of the import step )

Be aware that the actual import might happen after AbuseFilter triggered a warning.