Page MenuHomePhabricator

Improve handling of special pages in app - broken on EditPreview and Peek/Pop
Closed, DeclinedPublic

Description

Sometimes tapping an internal link shows a preview screen with a spinner that never goes away (see HelloWorld article on Test language, more more link). Turns out this is due to special pages.

Audit of special page handling

reading article, tap (should get page)

  • Normal page - works
  • UserTalk page - works
  • Special page - works

reading article, long press (should get preview)

  • Normal page - works
  • UserTalk page - nothing happens
  • Special page - nothing happens

edit preview, tap (should get preview)

  • Normal page - works
  • UserTalk page - previews header, but no body
  • Special page - broken, just shows spinner

edit preview, long press (should get preview)

  • Normal page - works
  • UserTalk page - broken (nothing is previewed)
  • Special page - broken (nothing is previewed)

Event Timeline

LGoto triaged this task as Medium priority.Jun 1 2020, 6:57 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

That link goes to Special:ListUsers. These pages are normally opened in-app in an embedded safari window, but with no native elements.

I'm guessing something goes wrong with Special pages in that flow. Digging in now.

Broader problems here - we have some issues in how special pages are handled in all preview situations (long press or from edit preview). Quick audit:

reading article, tap (should get page)

  • Normal page - works
  • UserTalk page - works
  • Special page - works

reading article, long press (should get preview)

  • Normal page - works
  • UserTalk page - nothing happens
  • Special page - nothing happens

edit preview, tap (should get preview)

  • Normal page - works
  • UserTalk page - previews header, but no body
  • Special page - broken, just shows spinner

edit preview, long press (should get preview)

  • Normal page - works
  • UserTalk page - broken (nothing is previewed)
  • Special page - broken (nothing is previewed)

Given that this is a bit larger than initially realized, I'm going to prioritize some other things right now, and come back to this.

MattCleinman renamed this task from Edit Preview link bug: internal links sometimes broken to Improve handling of special pages in app.Jul 14 2020, 6:41 PM
MattCleinman updated the task description. (Show Details)
MattCleinman renamed this task from Improve handling of special pages in app to Improve handling of special pages in app - broken on EditPreview and Peek/Pop.Jul 20 2020, 6:45 PM
LGoto lowered the priority of this task from Medium to Low.Jul 20 2020, 6:46 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
LGoto removed MattCleinman as the assignee of this task.