Page MenuHomePhabricator

PHP "cannot access private method LocalRepo::passThrough" from SpecialUpload->processUpload
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error message
PHP Warning: call_user_func() expects parameter 1 to be a valid callback, cannot access private method LocalRepo::passThrough()
Stack Trace
#0 /srv/mediawiki/php-1.35.0-wmf.34/includes/Status.php(173): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.34/includes/Status.php(298): Status->cleanParams(array)
#2 /srv/mediawiki/php-1.35.0-wmf.34/includes/Status.php(200): Status->getErrorMessage(array, LanguageEn)
#3 /srv/mediawiki/php-1.35.0-wmf.34/includes/specials/SpecialUpload.php(593): Status->getWikiText(boolean, boolean, LanguageEn)
#4 /srv/mediawiki/php-1.35.0-wmf.34/includes/specials/SpecialUpload.php(214): SpecialUpload->processUpload()
#5 /srv/mediawiki/php-1.35.0-wmf.34/includes/specialpage/SpecialPage.php(582): SpecialUpload->execute(NULL)
#6 /srv/mediawiki/php-1.35.0-wmf.34/includes/specialpage/SpecialPageFactory.php(623): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.34/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#8 /srv/mediawiki/php-1.35.0-wmf.34/includes/MediaWiki.php(978): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.35.0-wmf.34/includes/MediaWiki.php(535): MediaWiki->main()
#10 /srv/mediawiki/php-1.35.0-wmf.34/index.php(47): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Impact
  1. Notes

Details

Request ID
ee4cc358-262a-4c6b-a035-a2424a802076
Request URL
https://commons.wikimedia.org/wiki/Special:Upload

Event Timeline

Already roll out on Commons. Not sure whether this is causing problems in the upload stash or not. Could affect local wikis as well but uploads happen less often there.

I suggest not blocking the train, but I'm just tracking this here as it is a regression.

Change 599441 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Mark two FileRepo functions public

https://gerrit.wikimedia.org/r/599441

Change 599442 had a related patch set uploaded (by Jforrester; owner: Reedy):
[mediawiki/core@wmf/1.35.0-wmf.34] Mark two FileRepo functions public

https://gerrit.wikimedia.org/r/599442

Change 599442 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.34] Mark two FileRepo functions public

https://gerrit.wikimedia.org/r/599442

Change 599441 merged by jenkins-bot:
[mediawiki/core@master] Mark two FileRepo functions public

https://gerrit.wikimedia.org/r/599441

Mentioned in SAL (#wikimedia-operations) [2020-05-28T21:26:10Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.34/includes/filerepo/FileRepo.php: T253922 Mark two FileRepo functions public (duration: 01m 07s)

Jdforrester-WMF assigned this task to Reedy.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Provisionally fixed.