Page MenuHomePhabricator
Create Task
Maniphest T253935

Add a factory service for `RecentChange` objects
Closed, ResolvedPublic
Actions

Description

I propose creating a factory for RecentChanges that would inject the needed dependencies:

  • LoadBalancer (currently uses wfGetDB)
  • CommentStore (currently uses CommentStore::getStore())
  • ActorMigration (currently uses ActorMigration::newMigration())
  • HookContainer (currently uses Hooks::run())
  • PermissionManager
  • Global variables $wgPutIPinRC, $wgUseEnotif, $wgShowUpdatedMarker, $wgRCFeeds, $wgRCEngines, $wgUseRCPatrol, $wgUseNPPatrol, $wgUseFilePatrol, $wgLogRestrictions, $wgRCMaxAge

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Event Timeline

DannyS712 created this task.May 28 2020, 10:52 PM
Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptMay 28 2020, 10:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.May 28 2020, 10:52 PM
• Pchelolo moved this task from Inbox to Tech Planning Review on the Platform Engineering board.Jun 1 2020, 4:45 PM
• Pchelolo subscribed.Jun 1 2020, 4:51 PM

I believe that RC has to be converted to a value object, and all the DB-related stuff has to be moved into a new RecentChangeStore. Factory can be an interface implemented by the store, just like RevisionFactory and RevisionStore.

Perhaps the RC class after extracting DB functionality wouldn't be as pure as we'd want, since I see the, for example, 'getAttribute' loads comment from he comment store, but that could be implemented via some callbacks.

Some methods In RC, like 'doMarkPatrolled' probably doesn't belong in the store at all and should be moved elsewhere.

daniel triaged this task as Low priority.Aug 13 2020, 9:15 PM
daniel edited projects, added: Core Platform Team Initiatives (Decoupling (CDP2)); removed: Platform Engineering.
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM
KStoller-WMF removed projects: Growth-Team-Filtering, Growth-Team.Sep 13 2024, 5:42 PM
Zabe subscribed.Aug 15 2025, 5:06 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptAug 15 2025, 5:06 PM
Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Aug 19 2025, 11:35 AM
gerritbot added a comment.Aug 19 2025, 10:41 PM

Change #1180241 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Refactor RecentChange to use separate interfaces and services

https://gerrit.wikimedia.org/r/1180241

gerritbot added a project: Patch-For-Review.Aug 19 2025, 10:41 PM
Zabe claimed this task.Aug 20 2025, 7:17 PM
Zabe moved this task from Triaged to Code review requests on the Moderator-Tools-Team board.
Ladsgroup awarded a token.Aug 20 2025, 7:48 PM
gerritbot added a comment.Aug 20 2025, 10:15 PM

Change #1180672 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Introduce RecentChangePatrolManager

https://gerrit.wikimedia.org/r/1180672

gerritbot added a comment.Aug 21 2025, 12:01 AM

Change #1180684 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Start using new recent changes services

https://gerrit.wikimedia.org/r/1180684

gerritbot added a comment.Aug 21 2025, 12:16 AM

Change #1180686 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Introduce RecentChangeRCFeedNotifier

https://gerrit.wikimedia.org/r/1180686

gerritbot added a comment.Aug 21 2025, 12:51 AM

Change #1180691 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove a few methods from RecentChange without deprecation

https://gerrit.wikimedia.org/r/1180691

• Kgraessle moved this task from Code review requests to Kanban on the Moderator-Tools-Team board.Aug 21 2025, 3:43 PM
• Kgraessle edited projects, added: Moderator-Tools-Team (Kanban); removed: Moderator-Tools-Team.
• Kgraessle moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Aug 21 2025, 11:26 PM

Change #1180241 merged by jenkins-bot:

[mediawiki/core@master] Introduce RecentChangeStore

https://gerrit.wikimedia.org/r/1180241

gerritbot added a comment.Aug 21 2025, 11:43 PM

Change #1180686 merged by jenkins-bot:

[mediawiki/core@master] Introduce RecentChangeRCFeedNotifier

https://gerrit.wikimedia.org/r/1180686

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 22 2025, 12:00 AM
gerritbot added a comment.Aug 25 2025, 1:10 AM

Change #1180684 merged by jenkins-bot:

[mediawiki/core@master] Start using new recent changes services

https://gerrit.wikimedia.org/r/1180684

gerritbot added a comment.Aug 25 2025, 1:12 AM

Change #1180691 merged by jenkins-bot:

[mediawiki/core@master] Remove a few methods from RecentChange without deprecation

https://gerrit.wikimedia.org/r/1180691

gerritbot added a comment.Aug 25 2025, 1:12 AM

Change #1180672 merged by jenkins-bot:

[mediawiki/core@master] Introduce PatrolManager

https://gerrit.wikimedia.org/r/1180672

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2025, 1:30 AM
gerritbot added a comment.Aug 25 2025, 10:28 AM

Change #1181663 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Use new RecentChangeLookup methods

https://gerrit.wikimedia.org/r/1181663

gerritbot added a project: Patch-For-Review.Aug 25 2025, 10:28 AM
gerritbot added a comment.Aug 25 2025, 11:06 AM

Change #1181670 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/AbuseFilter@master] Replace deprecated RecentChange methods

https://gerrit.wikimedia.org/r/1181670

gerritbot added a comment.Aug 25 2025, 11:30 AM

Change #1181674 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Add type hinting to new recentchanges services

https://gerrit.wikimedia.org/r/1181674

matej_suchanek awarded a token.Aug 26 2025, 7:50 AM
gerritbot added a comment.Aug 26 2025, 8:09 AM

Change #1181670 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Replace deprecated RecentChange methods

https://gerrit.wikimedia.org/r/1181670

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.17; 2025-09-02); removed: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 26 2025, 9:00 AM
gerritbot added a comment.Aug 26 2025, 10:28 AM

Change #1181663 merged by jenkins-bot:

[mediawiki/core@master] Use new RecentChangeLookup methods

https://gerrit.wikimedia.org/r/1181663

• Kgraessle edited projects, added: Moderator-Tools-Team; removed: Moderator-Tools-Team (Kanban).Aug 26 2025, 3:00 PM
• Kgraessle moved this task from Inbox to Radar / Tracking on the Moderator-Tools-Team board.
gerritbot added a comment.Aug 29 2025, 12:33 AM

Change #1181674 merged by jenkins-bot:

[mediawiki/core@master] Add type hinting to new recentchanges services

https://gerrit.wikimedia.org/r/1181674

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2025, 1:30 AM
Zabe closed this task as Resolved.Sep 24 2025, 9:37 PM
Zabe edited projects, added: DBA; removed: MW-1.45-notes (1.45.0-wmf.17; 2025-09-02), Core Platform Team Initiatives (Decoupling (CDP2)).Oct 14 2025, 7:10 PM
Zabe moved this task from Triage to Done on the DBA board.
gerritbot added a comment.Mar 25 2026, 9:18 PM

Change #1260814 had a related patch set uploaded (by Reedy; author: Zabe):

[mediawiki/extensions/AbuseFilter@REL1_44] Replace deprecated RecentChange methods

https://gerrit.wikimedia.org/r/1260814

gerritbot added a project: Patch-For-Review.Mar 25 2026, 9:18 PM

Change #1260815 had a related patch set uploaded (by Reedy; author: Zabe):

[mediawiki/extensions/AbuseFilter@REL1_43] Replace deprecated RecentChange methods

https://gerrit.wikimedia.org/r/1260815

gerritbot added a comment.Mar 25 2026, 9:19 PM

Change #1260815 abandoned by Reedy:

[mediawiki/extensions/AbuseFilter@REL1_43] Replace deprecated RecentChange methods

https://gerrit.wikimedia.org/r/1260815

gerritbot added a comment.Mar 25 2026, 9:22 PM

Change #1260814 abandoned by Reedy:

[mediawiki/extensions/AbuseFilter@REL1_44] Replace deprecated RecentChange methods

https://gerrit.wikimedia.org/r/1260814

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2026, 9:31 PM
MGChecker subscribed.Apr 14 2026, 10:48 PM
gerritbot added a comment.Apr 14 2026, 11:08 PM

Change #1271077 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Hard-deprecate static RecentChange methods

https://gerrit.wikimedia.org/r/1271077

gerritbot added a project: Patch-For-Review.Apr 14 2026, 11:08 PM
gerritbot added a comment.Apr 15 2026, 1:29 PM

Change #1271077 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate static RecentChange methods

https://gerrit.wikimedia.org/r/1271077

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2026, 1:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits