Page MenuHomePhabricator
Create Task
Maniphest T253937

Watchlist Expiry: investigate star bug for action=watch page (beta) [8Hours]
Closed, ResolvedPublic
Actions

Description

As a PM, I want to know the reason why the star is not automatically updating upon watch on action=watch page (beta), so we can determine if this is a Watchlist Expiry bug.

Background: In the process of testing T248495, we found an issue (i.e., star status not changing until after page reload). This may be a beta environment issue, since the issue could not be replicated on local environments. It may also be a Watchlist Expiry issue. The purpose of this ticket is to investigate the issue & recommend next steps.

Acceptance Criteria:

  • Investigate why the relevant star shading is only displayed upon reload in beta on action=watch page
  • Propose and share solution to the problem
  • If a simple fix, implement fix to problem (otherwise, it can be handled in a separate ticket)

Visual Examples:

Example #1: I have watched a page temporarily (after not watching page at all), but the star is still not shaded

Screen Shot 2020-06-11 at 6.24.11 PM.png (313×1 px, 56 KB)

Example #2: I switched from watching temporarily to permanently, but I still see the half star

Screen Shot 2020-06-11 at 6.23.29 PM.png (361×1 px, 65 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Watchlist: Fix action=watch caching the wrong expirymediawiki/coreREL1_35+8 -8
Watchlist: Fix action=watch caching the wrong expirymediawiki/coremaster+8 -8
Customize query in gerrit

Related Objects

Event Timeline

ifried created this task.May 28 2020, 11:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2020, 11:19 PM
ifried renamed this task from Watchlist Expiry: investigate star bug on beta [placeholder] to Watchlist Expiry: investigate star bug for action=watch page (beta).May 29 2020, 12:08 AM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried added subscribers: Mooeypoo, ARamirez_WMF.
ifried updated the task description. (Show Details)Jun 11 2020, 10:27 PM
ARamirez_WMF renamed this task from Watchlist Expiry: investigate star bug for action=watch page (beta) to Watchlist Expiry: investigate star bug for action=watch page (beta) [8Hours].Jun 11 2020, 11:45 PM
ARamirez_WMF moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
ifried moved this task from Up Next (June 3-21) to Kanban-2019-20-Q4 on the Community-Tech board.Jun 11 2020, 11:55 PM
ifried edited projects, added Community-Tech (Kanban-2019-20-Q4); removed Community-Tech.
MusikAnimal claimed this task.Jun 23 2020, 8:45 PM
MusikAnimal moved this task from Ready to In Development on the Community-Tech (Kanban-2019-20-Q4) board.
MusikAnimal mentioned this in T256654: pages watched using the watchthis control in the wikitext editor do not show as watched after publishing until the page is reloaded.Jun 29 2020, 6:28 PM
MusikAnimal added a comment.Jun 29 2020, 8:18 PM

This is a long-standing issue, see T28292. It was partially fixed by Krinkle with https://gerrit.wikimedia.org/r/319255. Indeed it is broken again if the watchlist expiry feature flag is set :( I can't figure out why, though. A possible fix is to use the expiry when generating the cache key, but we can't do this because we don't know what the expiry is when we want to fetch the cached object. I've asked for help at T28292#6265657.

dmaza subscribed.Jul 2 2020, 6:18 PM
MusikAnimal reassigned this task from MusikAnimal to dmaza.Jul 8 2020, 6:40 PM
MusikAnimal subscribed.
MBinder_WMF edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech (Kanban-2019-20-Q4).Jul 14 2020, 7:21 PM
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban-2020-21-Q1). · View Herald TranscriptJul 14 2020, 7:21 PM
MBinder_WMF edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.Jul 14 2020, 7:23 PM
ARamirez_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 14 2020, 7:24 PM
dom_walden subscribed.Jul 23 2020, 8:41 AM

I have also started to see this problem on https://test.wikipedia.org (MediaWiki 1.36.0-wmf.1 (rMW652572fd47fb) 18:24, 22 July 2020).

dmaza added a comment.Jul 23 2020, 9:45 PM
In T253937#6328712, @dom_walden wrote:

I have also started to see this problem on https://test.wikipedia.org (MediaWiki 1.36.0-wmf.1 (rMW652572fd47fb) 18:24, 22 July 2020).

Yup, that's to be expected. Thanks for mentioning it

Aklapper added a comment.Jul 24 2020, 10:12 AM

T256654 weclomes rechecking once this has been resolved.

dom_walden mentioned this in T250215: Watchlist Expiry: Display remaining watch period via star [small].Jul 27 2020, 8:57 AM
gerritbot added a comment.Jul 28 2020, 4:13 AM

Change 616647 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Watchlist: Fix action=watch caching the wrong expiry

https://gerrit.wikimedia.org/r/616647

gerritbot added a project: Patch-For-Review.Jul 28 2020, 4:13 AM
dmaza moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 28 2020, 3:13 PM
gerritbot added a comment.Jul 28 2020, 9:00 PM

Change 616647 merged by jenkins-bot:
[mediawiki/core@master] Watchlist: Fix action=watch caching the wrong expiry

https://gerrit.wikimedia.org/r/616647

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2020, 9:10 PM
dmaza moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 28 2020, 9:13 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 28 2020, 10:00 PM
gerritbot added a comment.Jul 29 2020, 3:41 AM

Change 616972 had a related patch set uploaded (by Samwilson; owner: Dmaza):
[mediawiki/core@REL1_35] Watchlist: Fix action=watch caching the wrong expiry

https://gerrit.wikimedia.org/r/616972

gerritbot added a project: Patch-For-Review.Jul 29 2020, 3:41 AM
gerritbot added a comment.Jul 29 2020, 4:00 AM

Change 616972 merged by jenkins-bot:
[mediawiki/core@REL1_35] Watchlist: Fix action=watch caching the wrong expiry

https://gerrit.wikimedia.org/r/616972

ReleaseTaggerBot added a project: MW-1.35-notes.Jul 29 2020, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 4:10 AM
dom_walden added a comment.Jul 31 2020, 9:36 AM
In T253937#6332586, @Aklapper wrote:

T256654 weclomes rechecking once this has been resolved.

I can still reproduce this issue on https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (72ac5e1) 06:44, 31 July 2020.

dmaza added a comment.Jul 31 2020, 2:12 PM
In T253937#6351073, @dom_walden wrote:
In T253937#6332586, @Aklapper wrote:

T256654 weclomes rechecking once this has been resolved.

I can still reproduce this issue on https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (72ac5e1) 06:44, 31 July 2020.

This is a separate issue tho. The patch for this tasks solves it when watching/unwatching via action=watch

dom_walden moved this task from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 31 2020, 2:38 PM

The bug no longer happens on beta when submitting action=watch.

Doing the transition from:

  • Unwatched to temp watched
  • Unwatched to perm watched
  • Perm watched to temp watched
  • Perm watched to perm watched
  • Temp watched to temp watched
  • Temp watched to perm watched

It has the correct watch star image and expiry in the tooltip (if applicable) on the submit page.

Because this code is used in a few places, I retested Special:EditWatchlist/raw could add a new watched page.

As mentioned in T253937#6351073, I don't think this fixes the issue while editing.

Also, I don't think beta has a replica database like production has. Reading the commit message, this might have an impact on the behaviour. Might be worth retesting once this goes to production (e.g. on testwiki). I've added a TODO item for myself.

Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (58b7003) 13:38, 31 July 2020

dom_walden added a comment.Jul 31 2020, 2:48 PM
In T253937#6351801, @dmaza wrote:
In T253937#6351073, @dom_walden wrote:

I can still reproduce this issue on https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (72ac5e1) 06:44, 31 July 2020.

This is a separate issue tho. The patch for this tasks solves it when watching/unwatching via action=watch

No problem. I was just commenting as an FYI.

ifried added a comment.EditedAug 3 2020, 9:56 PM

@dmaza Hey, there! I wanted to check about one thing: We have talked about how the fix for action=watch (i.e., this ticket) and source editing (T259564) would need to be separate. However, when I tested this on testwiki today, I saw that *both* the action=watch bug and the source editing bug for the star seemed to be fixed. However, on beta, it appears that only the action=watch bug is fixed. Is this because of the most recent changes being deployed to beta, but not testwiki yet? Just wanted to ping you and make sure I understand the current status correctly. Thanks!

dmaza added a comment.Aug 5 2020, 7:54 PM
In T253937#6357876, @ifried wrote:

@dmaza Hey, there! I wanted to check about one thing: We have talked about how the fix for action=watch (i.e., this ticket) and source editing (T259564) would need to be separate. However, when I tested this on testwiki today, I saw that *both* the action=watch bug and the source editing bug for the star seemed to be fixed. However, on beta, it appears that only the action=watch bug is fixed. Is this because of the most recent changes being deployed to beta, but not testwiki yet? Just wanted to ping you and make sure I understand the current status correctly. Thanks!

Are you talking about T256654: pages watched using the watchthis control in the wikitext editor do not show as watched after publishing until the page is reloaded? is T259564: Watchlist Expiry: update watch status when editing via dropdown [[LARGE]] the same? in any case, the fix for this task is not fixing either. I'm currently looking at T256654

ifried closed this task as Resolved.EditedAug 5 2020, 9:10 PM
ifried moved this task from Product sign-off 🤘🏻 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q1) board.

The question I originally asked has been resolved in a conversation with @dmaza. We discussed the fact that the action=watch bug and the source editing bug will be resolved in separate tickets. Furthermore, while there may be some questions if the source editing bug is indeed fixed, or if the bug can reproduced in local environments, they will be addressed in a separate ticket. We'll look into T256654 and T259564 & see if/how they are related, as well.

Meanwhile, the actual focus of this ticket (i.e., the bug of the star not automatically updating upon temporary watch via action=watch) has been resolved. I have tested on testwiki, and the issue is no longer reproducible. For this reason, I'm marking this ticket as Done.

MusikAnimal mentioned this in T259379: Watchlist Expiry: fix WatchItem cache when automatically adding a page to your watchlist via rollback [[MEDIUM]].Aug 11 2020, 9:28 PM
dmaza mentioned this in T260868: Normalize WatchedItem expiry field.Aug 20 2020, 3:51 AM
dom_walden mentioned this in T263160: Watchlist Expiry: action=unwatch has caching issue.Sep 17 2020, 5:26 PM
ifried mentioned this in T28292: Skin should show "Watch" (not "Unwatch") tab on action=unwatch response.Sep 17 2020, 11:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits