Enable DiscussionTools at all wikis via query string
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	May 29 2020, 1:06 AM

Description

This task is about making the Reply tool available via the following URL parameter: ?dtenable=1.

Requirements

URL parameter that should be used to enable the tool: ?dtenable=1
~~Wikipedias~~ Wikis where the tool should be available via the URL parameter: all
Text input mode that should be made available via the URL parameter: source and visual

Done

The Reply tool should be deployed in a way that meets the "Requirements" listed above

Details

Project	Branch	Lines +/-	Subject
operations/mediawiki-config	master	+5 -7	Install DiscussionTools on all wikis (attempt 2)
mediawiki/extensions/DiscussionTools	wmf/1.35.0-wmf.37	+3 -2	Use $wgLocaltimezone global instead of request context
operations/mediawiki-config	master	+7 -5	Revert "Install DiscussionTools on all wikis"
operations/mediawiki-config	master	+5 -7	Install DiscussionTools on all wikis

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Resolved	matmarex	T253943 Enable DiscussionTools at all wikis via query string

Event Timeline

ppelberg created this task.May 29 2020, 1:06 AM

ppelberg moved this task from Needs Discussion / Investigation to Upcoming on the Editing-team (Q3 2019-2020 Kanban Board) board.

ppelberg mentioned this in T252264: Deploy Reply tool via query string parameter to zh.wiki.

Taiwania_Justo added a subscriber: Taiwania_Justo.May 30 2020, 10:08 AM

Update
Notes from today's stand...

This change will need to be made via a config change
The tool's visual mode should be available via the ?dtenable=1 URL parameter

Next steps

@ppelberg to notify engineering during which backport window this change should be deployed in.

Change 599307 had a related patch set uploaded (by Esanders; owner: Esanders):
[operations/mediawiki-config@master] Install DiscussionTools on all wikis

https://gerrit.wikimedia.org/r/599307

gerritbot added a project: Patch-For-Review.Jun 15 2020, 7:01 PM

In T253943#6225233, @ppelberg wrote:

Next steps

@ppelberg to notify engineering during which backport window this change should be deployed in.

This should be deployed tomorrow, 17-June.

cc @Esanders

The above has been added to the task description.

ppelberg moved this task from Upcoming to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 16 2020, 11:50 PM

ppelberg updated the task description. (Show Details)Jun 16 2020, 11:53 PM

Esanders renamed this task from Enable DiscussionTools at all Wikipedias via query string to Enable DiscussionTools at all wikis via query string.Jun 17 2020, 11:29 AM

ppelberg assigned this task to matmarex.Jun 17 2020, 5:41 PM

ppelberg updated the task description. (Show Details)

Change 599307 merged by jenkins-bot:
[operations/mediawiki-config@master] Install DiscussionTools on all wikis

https://gerrit.wikimedia.org/r/599307

Mentioned in SAL (#wikimedia-operations) [2020-06-17T18:24:15Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: REVERT: ae76450: Install DiscussionTools on all wikis (T252264; T253943) (duration: 00m 34s)

Change 606235 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Revert "Install DiscussionTools on all wikis"

https://gerrit.wikimedia.org/r/606235

Change 606235 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Install DiscussionTools on all wikis"

https://gerrit.wikimedia.org/r/606235

I've reverted the change, because it caused fatal errors at commonswiki. Logstash link: https://logstash.wikimedia.org/goto/e474f13ffac6b8c3bf919c4aeafc8c9b.

Looks like DiscussionTools conflicts with WikibaseMediaInfo for some insane reason. I will try to reproduce and debug this locally later.

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2020, 7:10 PM

(The problem is filed as T255704)

Change 606279 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/DiscussionTools@wmf/1.35.0-wmf.37] Use $wgLocaltimezone global instead of request context

https://gerrit.wikimedia.org/r/606279

Change 606280 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Install DiscussionTools on all wikis (attempt 2)

https://gerrit.wikimedia.org/r/606280

Change 606279 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.35.0-wmf.37] Use $wgLocaltimezone global instead of request context

https://gerrit.wikimedia.org/r/606279

Change 606280 merged by jenkins-bot:
[operations/mediawiki-config@master] Install DiscussionTools on all wikis (attempt 2)

https://gerrit.wikimedia.org/r/606280

Mentioned in SAL (#wikimedia-operations) [2020-06-17T23:21:49Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.37/extensions/DiscussionTools/includes/Hooks.php: 4551d29: Use $wgLocaltimezone global instead of request context (T252264; T253943; T255704) (duration: 00m 58s)

Mentioned in SAL (#wikimedia-operations) [2020-06-17T23:25:03Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 0e7079d: Install DiscussionTools on all wikis (attempt 2) (T252264; T253943) (duration: 00m 56s)

matmarex moved this task from Doing to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 17 2020, 11:46 PM

Looks good now.

In T253943#6233685, @matmarex wrote:

Looks good now.

+1. Tested in the following places:

Maintenance_bot removed a project: Patch-For-Review.Jun 18 2020, 12:10 AM

VulpesVulpes825 mentioned this in T258554: Enable discussion tools on discussion pages on the Konkani Wiktionary.Jul 22 2020, 9:36 AM

Enable DiscussionTools at all wikis via query stringClosed, ResolvedPublicActions