Page MenuHomePhabricator

intersection parser test failures
Closed, ResolvedPublic

Description

13:55:28 1) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=gallery (complex, no image)" ('[details omitted]')
13:55:28 Failed asserting that two strings are equal.
13:55:28 --- Expected
13:55:28 +++ Actual
13:55:28 @@ @@
13:55:28 -'<ul class="gallery mw-gallery-traditional" style="max-width: 791px;_width: 791px;">\n
13:55:28 +'<ul class="gallery mw-gallery-traditional" style="max-width: 791px;">\n
13:55:28  	<li class="gallerycaption">Look at my pretty gallery. http://example.org</li>\n
13:55:28  		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
13:55:28  			<div class="thumb" style="height: 150px;">Yet another DPL test page!</div>\n
13:55:28 
13:55:28 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:65
13:55:28 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:25
13:55:28 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:25
13:55:28 /workspace/src/maintenance/doMaintenance.php:105
13:55:28 2) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=gallery (complex, with image + bad image)" ('[details omitted]')
13:55:28 Failed asserting that two strings are equal.
13:55:28 --- Expected
13:55:28 +++ Actual
13:55:28 @@ @@
13:55:28 -'<ul class="gallery mw-gallery-traditional" style="max-width: 791px;_width: 791px;">\n
13:55:28 +'<ul class="gallery mw-gallery-traditional" style="max-width: 791px;">\n
13:55:28  	<li class="gallerycaption">I love Captions</li>\n
13:55:28  		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
13:55:28  			<div class="thumb" style="width: 100px;"><div style="margin:25.5px auto;"><a href="/wiki/File:LoremIpsum.djvu" class="image"><img alt="LoremIpsum.djvu" src="http://example.com/images/thumb/5/5f/LoremIpsum.djvu/page1-70px-LoremIpsum.djvu.jpg" decoding="async" width="70" height="99" srcset="http://example.com/images/thumb/5/5f/LoremIpsum.djvu/page1-105px-LoremIpsum.djvu.jpg 1.5x, http://example.com/images/thumb/5/5f/LoremIpsum.djvu/page1-140px-LoremIpsum.djvu.jpg 2x" /></a></div></div>\n
13:55:28 
13:55:28 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:65
13:55:28 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:25
13:55:28 /workspace/src/tests/phpunit/suites/SuiteEventsTrait.php:25
13:55:28 /workspace/src/maintenance/doMaintenance.php:105

Event Timeline

Reedy renamed this task from intersection browser test failures to intersection parser test failures.May 30 2020, 1:54 PM

Change 601355 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/intersection@master] Remove more IE6 and IE7 compatibility

https://gerrit.wikimedia.org/r/601355

Change 601370 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/intersection@master] Unbreak repo by updating parser tests to drop _width gallery output

https://gerrit.wikimedia.org/r/601370

Change 601370 abandoned by Jforrester:
Unbreak repo by updating parser tests to drop _width gallery output

Reason:
Aha, dupe of If71a2090a.

https://gerrit.wikimedia.org/r/601370

Change 601355 merged by Jforrester:
[mediawiki/extensions/intersection@master] Remove more IE6 and IE7 compatibility

https://gerrit.wikimedia.org/r/601355