Page MenuHomePhabricator
Create Task
Maniphest T254087

Remove unused Title::nameOf in MediaWiki Core
Closed, ResolvedPublic
Actions

Description

Title::nameOf can be used to retrieve the prefixed DB key associated with a page ID. It currently has no known callers[1], and it accesses the global state (via wfGetDB), which should be discouraged.

Any reason it can't be deprecated and removed?

[1] https://codesearch.wmflabs.org/search/?q=nameOf%5C(&i=nope&files=&repos=

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Deprecate Title::nameOf()mediawiki/coremaster+5 -0
Customize query in gerrit

Event Timeline

DannyS712 created this task.May 31 2020, 1:36 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMay 31 2020, 1:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Others on the User-DannyS712 board.May 31 2020, 1:36 AM
DannyS712 added a project: good first task.
Aklapper renamed this task from Title::nameOf is unused to Remove unused Title::nameOf in MediaWiki Core.May 31 2020, 8:10 AM
• Pchelolo moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Jun 1 2020, 4:45 PM
• Pchelolo subscribed.Jun 2 2020, 5:37 PM

Why not? I'd say yeah, go for it

• Pchelolo moved this task from Triage Meeting Inbox to Volunteer Needed Tasks on the Platform Engineering board.Jun 2 2020, 5:38 PM
Southparkfan claimed this task.Aug 23 2020, 11:36 PM
gerritbot added a comment.Aug 23 2020, 11:38 PM

Change 621968 had a related patch set uploaded (by Southparkfan; owner: Southparkfan):
[mediawiki/core@master] Deprecate Title::nameOf()

https://gerrit.wikimedia.org/r/621968

gerritbot added a project: Patch-For-Review.Aug 23 2020, 11:38 PM
gerritbot added a comment.Aug 24 2020, 3:44 PM

Change 621968 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Title::nameOf()

https://gerrit.wikimedia.org/r/621968

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 24 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 24 2020, 4:10 PM
Jdforrester-WMF subscribed.Sep 17 2020, 4:22 PM

[Now waiting for the MW 1.37 cycle.]

DannyS712 moved this task from Untriaged to Not yet on the Technical-Debt (Deprecation process) board.Sep 17 2020, 5:12 PM
Zabe closed this task as Resolved.Jun 1 2021, 8:47 PM
Zabe subscribed.

Got removed with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/684501

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits