| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| peek: Reenable cron with correct params | operations/puppet | production | +12 -8 | |
| peek: Disable cron execution | operations/puppet | production | +2 -0 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T294906 Puppet Improvements | |||
| Duplicate | jbond | T265138 Work required to prepare for puppet 7 | |||
| Resolved | SLyngshede-WMF | T273673 replace all puppet crons with systemd timers | |||
| Open | None | T132324 Tracking and Reducing cron-spam to root@ | |||
| Resolved | • chasemp | T254127 peek is incorrectly configured to run every minute every 1st of the month, creating large amounts of cronspam |
Event Timeline
Comment Actions
Change 601170 had a related patch set uploaded (by Jcrespo; owner: Jcrespo):
[operations/puppet@production] peek: Disable cron execution
Comment Actions
Change 601170 merged by Jcrespo:
[operations/puppet@production] peek: Disable cron execution
Comment Actions
Change 601173 had a related patch set uploaded (by Jcrespo; owner: Jcrespo):
[operations/puppet@production] peek: Reenable cron with the correct configuration
Comment Actions
812 reports were sent today 1st June.
The scheduling seems an unintended mixup with cron parameters (* * instead of, e.g. 0 1). It is unclear to me, however, the intention of reporting output, is an email sent by the script and the stdout to root on purpose? Shouldn't the cron be better configured with a systemd timer T210818 and monitor systemd status?
I chose to disable it given it is a report and it could affect Phabricator performance, reenabling can be done at: https://gerrit.wikimedia.org/r/c/operations/puppet/+/601173 but needs Security-Team input (@chasemp).
Comment Actions
Thanks for disabling @jcrespo, sorry for the avalanche. Systemd timer seems like a sane idea.
Comment Actions
Change 601173 merged by Rush:
[operations/puppet@production] peek: Reenable cron with correct params
Comment Actions
sudo -u peek crontab -l # HEADER: This file was autogenerated at 2020-06-10 16:26:11 +0000 by puppet. # HEADER: While it can still be managed manually, it is definitely not recommended. # HEADER: Note particularly that the comments starting with 'Puppet Name' should # HEADER: not be deleted, as doing so could cause duplicate cron jobs. # Puppet Name: peek_monthly MAILTO=security-team@wikimedia.org 0 0 1 * * . $HOME/.profile; /var/lib/peek/git/peek.py -c /etc/peek/config/base.conf,/etc/peek/config/monthly.conf -s > /dev/null # Puppet Name: peek_weekly MAILTO=security-team@wikimedia.org 0 0 * * 1 . $HOME/.profile; /var/lib/peek/git/peek.py -c /etc/peek/config/base.conf,/etc/peek/config/weekly.conf -s > /dev/null