Page MenuHomePhabricator

Support adding image tags from Commons filepage
Closed, ResolvedPublic4 Estimated Story Points

Description

Outline

As mentioned in T250192.

This will be a CTA like the others (e.g., add Wikidata descriptions).

Will need unique tag per source (e.g., filepage, SE feed, etc)

Designs

0102030405060708

👉 Zeplin

Description

  • Ideally, we also allow users to edit image tags (see image 06).
    • The flow for editing tags is the same as for adding tags.
      • Tags that users disable and publish during an edit session won’t be displayed anymore in the next edit session (of any user for that particular file).
  • About image captions editing on the file page
    • Show the (unstructured) image description with the edit pencil when there’s no structured caption.
    • Show the image caption CTA when there’s no (structured + unstructured) description at all (08)
    • The flow’s the same as for image caption CTA in the gallery / article view.
    • Users will be redirected to the file page after adding an image caption.
    • Be aware of the work in T257941 for this task.
  • Consider implementing T240195 as well for reasons of consistency with other Suggested edit tasks.
  • If the user can see the contribution on the current page (e.g. article description for the PageActivity or image caption for the GalleryActivity), then don't show the View action in the snackbar.
  • Special case: in the FilePageActivity, don‘t show the Image tag(s) published! since users can view tags right away and the “Published” confirmation is already shown (animation).

Event Timeline

@Dbrant we will need to add a "source" tag to track where the tag action originated since we are adding CTAs for tagging. Let's discuss where that will fit since the current actual source field is occupied with the '#suggestededit-imgtag-custom 1.0'

We will need the names of CTA location/prompt when they are ready, @Dbrant will add them to the analytics for image tags in table MobileWikiAppEdit. Tags will be modified from '#suggestededit-imgtag-custom 1.0' to '#suggestededit-imgtag-custom_$SOURCE 1.0'

SNowick_WMF lowered the priority of this task from High to Medium.Jul 15 2020, 12:30 AM
SNowick_WMF moved this task from Triage to Kanban on the Product-Analytics board.
SNowick_WMF moved this task from Next 2 weeks to Blocked on the Product-Analytics (Kanban) board.

While working on this — I realized that we did not implement T240195 in V4. I think we should also consider it for the next release — unless there’s something I’m missing (or not remembering). What do you think @Charlotte ?

While working on this — I realized that we did not implement T240195 in V4. I think we should also consider it for the next release — unless there’s something I’m missing (or not remembering). What do you think @Charlotte ?

You're missing that the ticket is already in this sprint and in progress. 😃

@Charlotte

You're missing that the ticket is already in this sprint and in progress. 😃

🚀🍪🚀

schoenbaechler added subscribers: Sharvaniharan, cooltey.

@Charlotte @cooltey @Sharvaniharan @Dbrant

Per our discussion at standup, I updated the task’s description with details and visuals on image caption editing!

This comment was removed by cooltey.

Please ignore the comment above if you have seen it.

Looks good @cooltey. I just realized that there’s a publish snackbar that says:

Image tag(s) published! GET STARTED

As we’re already having a PUBLISH confirmation/animation within the add image tag flow, we don’t need a snackbar in this case. Ideally, we show the snackbar that just says:

Enjoyed that? Help us add missing tags to other images.

... based on the criteria described in T257941

@schoenbaechler
Sure, will do it. I have noticed that the Image tag(s) published! snackbar also shown on the Explore feed and article page CTA after published the image tags.

Now they all will show the SE feed link action with the message above; if the user is not selected in the A/B test group, then no snackbar will show.

@cooltey

Re: this 👇

Sure, will do it. I have noticed that the Image tag(s) published! snackbar also shown on the Explore feed and article page CTA after published the image tags.

I thought about this a little more and think that we’re making a mistake by removing it, since people can’t view their actual contribution anymore. On Explore, Article and Gallery — people won’t have an option to view their contribution anymore. Contributions via File page are different, as people are already on the file page — so no need to show them a snackbar with the View link.


In summary (for image tags):

On the file page, show this snackbar (max 2x per session):

Enjoyed that? Help us add more.

GET STARTED

On Explore, Article and Gallery, show these snackbars:

01) Enjoyed that? Help us add more.

GET STARTED

(max 2x per session)

02) Image tag(s) published!

VIEW


Hope that is clear enough? If not, here’s a flow chart:

https://whimsical.com/6pCkB8tqtxKDUmX7QYrFLW

Thanks!

btw. @cooltey — I’m not seeing Suggested edits in the Explore feed in the latest Alpha anymore? 🤔

@cooltey

Re: this 👇

Sure, will do it. I have noticed that the Image tag(s) published! snackbar also shown on the Explore feed and article page CTA after published the image tags.

I thought about this a little more and think that we’re making a mistake by removing it, since people can’t view their actual contribution anymore. On Explore, Article and Gallery — people won’t have an option to view their contribution anymore. Contributions via File page are different, as people are already on the file page — so no need to show them a snackbar with the View link.


In summary (for image tags):

On the file page, show this snackbar (max 2x per session):

Enjoyed that? Help us add more.

GET STARTED

On Explore, Article and Gallery, show these snackbars:

01) Enjoyed that? Help us add more.

GET STARTED

(max 2x per session)

02) Image tag(s) published!

VIEW


Hope that is clear enough? If not, here’s a flow chart:

https://whimsical.com/6pCkB8tqtxKDUmX7QYrFLW

Thanks!

Hi @schoenbaechler

Thanks for the flowchart, but I think right now the logic is getting more complicated, can we have a consistent logic of showing the snackbars for all the places?

For now, in the "article page", the SE feed link snackbar will show right after the "published" snackbar is dismissed, and this against the logic in your flow chart.

In article page:
Published image caption -> "published" snackbar shown -> "published" snackbar dismissed -> SE feed link snackbar shown (2x per session)

In Explore feed, Gallery and File page:
Published image caption -> SE feed link snackbar shown (2x per session)
then
Published image caption -> "published" snackbar shown

...

Would it be possible to have a consistent logic for these cases? It would reduce the difficulty of maintaining the code because it is also including the AB testing.

@cooltey, thx for the suggestions.

For now, in the "article page", the SE feed link snackbar will show right after the "published" snackbar is dismissed, and this against the logic in your flow chart.

Hmm, I think we’re on the same page but are “lost in communication”. I had exactly what you describe here in mind for all cases:

  1. Always show Publish snackbar first
  2. Then show Enjoyed that snackbar (2x per session)

I think we might need to chat tonight (after grooming) and update the flow chart together to get it right, ok? It’ll help Shay too.

Thanks, @schoenbaechler.

Per our discussion, the current flow would be:

  1. Always show Publish snackbar first
  2. Then show a general Enjoyed that? Help us add more. snackbar (2x per session)
Note
  • Removed the previous Snackbars that combines the "published" text with SE feed link promotion text:
    • {{SOURCE}} published. Enjoyed that? Help us add more. -> removed
  • If the current page can see the contribution (e.g. article description for the PageActivity or image caption for the GalleryActivity), then don't show the View action in the snackbar.
  • Special case: in the FilePageActivity, don't show the Image tag(s) published! since we can view the tags and the publish screen already shows the "published" animation.

Please update the note to the ticket description if that looks good to you. 😄

@cooltey — looks good!

One note → the app keeps crashing when I want to edit / try out the new snackbar behavior (T254142#6410763) via Explore feed:

https://www.dropbox.com/s/o109xl3pntze3ek/crash.mp4?dl=0

Wasn’t able to test this.

Thanks, @schoenbaechler. Fixed.
One thing I would like to remind that the sequential snackbar (the SE feed link) will show only if the user keeps on the same screen when the first snackbar is dismissed.

We will need the names of CTA location/prompt when they are ready, @Dbrant will add them to the analytics for image tags in table MobileWikiAppEdit. Tags will be modified from '#suggestededit-imgtag-custom 1.0' to '#suggestededit-imgtag-custom_$SOURCE 1.0'

@Dbrant Do we have a 'source' designation for image tags in the new data format?

Since we don't have a distinct source for image tags from Commons filepage we will count these new image tags with the regular image tags as Suggested Edit actions. Closing ticket.