Page MenuHomePhabricator
Create Task
Maniphest T254181

Run parserTests with Parsoid in extension repos
Closed, ResolvedPublic
Actions

Description

When an extension implements a ParsoidModule you need to be able to run its parserTests with parsoid (as well as with the legacy parser).

Details

SubjectRepoBranchLines +/-
Move Parsoid disambiguator parser tests to Extension:Disambiguatormediawiki/extensions/Disambiguatormaster+15 -1
ParserTestReader: Support a generalized file-level options clausemediawiki/services/parsoidmaster+375 -285
Add support for running parsertests with Parsoid in integrated modemediawiki/coremaster+317 -45
ParserTestRunner: add interwiki prefixes used by Parsoid testsmediawiki/coremaster+23 -0
ParserTestRunner: tweak filetype of djvu, allow capital E in !!hooksmediawiki/coremaster+2 -2
Parser tests: Update TestFileReader to the latest reader from Parsoidmediawiki/coremaster+6 -5
Use parser test file parser from Parsoidmediawiki/coremaster+76 -414
Bump wikimedia/parsoid to v0.13.0-a6mediawiki/vendormaster+462 -231
Allow parser test files to end w/o a trailing newlinemediawiki/services/parsoidmaster+13 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Jun 1 2020, 4:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 1 2020, 4:56 PM
cscott added a parent task: T133320: Unified extension registration mechanism for core/VE/Parsoid.Jun 1 2020, 4:57 PM
Aklapper added a project: Parsoid.Jun 1 2020, 6:50 PM
ssastry triaged this task as High priority.Jun 4 2020, 8:06 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Jun 4 2020, 8:13 PM
ssastry added a project: Parsing-Active-Work.Jun 8 2020, 3:11 PM
ssastry moved this task from Incoming Work (but not yet ready) to Todo (Roadmap Critical Path) on the Parsing-Active-Work board.
ssastry lowered the priority of this task from High to Medium.Jun 11 2020, 1:29 AM
ssastry moved this task from Testing to Current & Upcoming Work on the Parsoid board.Jul 2 2020, 6:40 PM
ssastry assigned this task to cscott.Jul 15 2020, 7:18 PM
ssastry moved this task from Todo (Roadmap Critical Path) to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.Jul 23 2020, 5:39 PM
gerritbot added a comment.Aug 4 2020, 5:03 AM

Change 613317 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Use parser test file parser from Parsoid

https://gerrit.wikimedia.org/r/613317

gerritbot added a project: Patch-For-Review.Aug 4 2020, 5:03 AM
gerritbot added a comment.Aug 4 2020, 6:54 PM

Change 618372 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Allow parser test files to end w/o a trailing newline

https://gerrit.wikimedia.org/r/618372

gerritbot added a comment.Aug 6 2020, 5:55 PM

Change 618372 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Allow parser test files to end w/o a trailing newline

https://gerrit.wikimedia.org/r/618372

ssastry added a subtask: T234932: Parsoid srcset is inconsistent with core.Aug 6 2020, 5:58 PM
ssastry closed subtask T234932: Parsoid srcset is inconsistent with core as Resolved.Aug 6 2020, 8:18 PM
gerritbot added a comment.Aug 17 2020, 5:30 PM

Change 620755 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a6

https://gerrit.wikimedia.org/r/620755

gerritbot added a comment.Aug 17 2020, 6:31 PM

Change 620755 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a6

https://gerrit.wikimedia.org/r/620755

gerritbot added a comment.Aug 17 2020, 8:37 PM

Change 613317 merged by jenkins-bot:
[mediawiki/core@master] Use parser test file parser from Parsoid

https://gerrit.wikimedia.org/r/613317

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 17 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 17 2020, 9:11 PM
cscott mentioned this in T133320: Unified extension registration mechanism for core/VE/Parsoid.Aug 26 2020, 4:56 PM

Didn't get this done for 1.35; retargetting to 1.36.

cscott edited parent tasks, added: T261329: Prepare Parsoid for MW; removed: T133320: Unified extension registration mechanism for core/VE/Parsoid.Aug 26 2020, 4:57 PM
ssastry added a subtask: T94793: Support ImageMap extension in Parsoid.Sep 24 2020, 6:46 PM
ssastry removed a subtask: T94793: Support ImageMap extension in Parsoid.
ssastry added parent tasks: T107332: Parsoid-native implementation for <indicator> (page status indicators), T94793: Support ImageMap extension in Parsoid.
cscott mentioned this in T265518: Move Parsoid ServiceWorker.php and extension/src/Config into core.Oct 14 2020, 6:07 PM
gerritbot added a comment.Dec 11 2020, 10:11 PM

Change 648357 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] ParserTestReader: Support a generalized file-level options clause

https://gerrit.wikimedia.org/r/648357

gerritbot added a project: Patch-For-Review.Dec 11 2020, 10:11 PM
gerritbot added a comment.Dec 11 2020, 11:38 PM

Change 615924 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Add support for running parsertests *with parsoid*

https://gerrit.wikimedia.org/r/615924

gerritbot added a comment.Dec 11 2020, 11:38 PM

Change 648378 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Parser tests: Update TestFileReader to the latest reader from Parsoid

https://gerrit.wikimedia.org/r/648378

gerritbot added a comment.Dec 12 2020, 4:35 AM

Change 648461 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Disambiguator@master] Move Parsoid disambiguator parser tests to Extension:Disambiguator

https://gerrit.wikimedia.org/r/648461

gerritbot added a comment.Dec 12 2020, 5:06 AM

Change 648357 merged by jenkins-bot:
[mediawiki/services/parsoid@master] ParserTestReader: Support a generalized file-level options clause

https://gerrit.wikimedia.org/r/648357

gerritbot added a comment.Dec 16 2020, 5:45 PM

Change 648378 merged by jenkins-bot:
[mediawiki/core@master] Parser tests: Update TestFileReader to the latest reader from Parsoid

https://gerrit.wikimedia.org/r/648378

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Dec 16 2020, 6:00 PM
gerritbot added a comment.Dec 21 2020, 7:11 PM

Change 651236 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] ParserTestRunner: tweak filetype of djvu, allow capital E in !!hooks

https://gerrit.wikimedia.org/r/651236

gerritbot added a comment.Dec 21 2020, 7:11 PM

Change 650621 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] ParserTestRunner: add interwiki prefixes used by Parsoid tests

https://gerrit.wikimedia.org/r/650621

gerritbot added a comment.Dec 21 2020, 11:23 PM

Change 651236 merged by jenkins-bot:
[mediawiki/core@master] ParserTestRunner: tweak filetype of djvu, allow capital E in !!hooks

https://gerrit.wikimedia.org/r/651236

gerritbot added a comment.Dec 21 2020, 11:24 PM

Change 650621 merged by jenkins-bot:
[mediawiki/core@master] ParserTestRunner: add interwiki prefixes used by Parsoid tests

https://gerrit.wikimedia.org/r/650621

gerritbot added a comment.Dec 25 2020, 5:39 PM

Change 615924 merged by jenkins-bot:
[mediawiki/core@master] Add support for running parsertests with Parsoid in integrated mode

https://gerrit.wikimedia.org/r/615924

gerritbot added a comment.Jan 12 2021, 8:29 PM

Change 648461 merged by jenkins-bot:
[mediawiki/extensions/Disambiguator@master] Move Parsoid disambiguator parser tests to Extension:Disambiguator

https://gerrit.wikimedia.org/r/648461

cscott mentioned this in rEDISf9e5a56bf8d4: Move Parsoid disambiguator parser tests to Extension:Disambiguator.Jan 12 2021, 8:31 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.27; 2021-01-19); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 12 2021, 9:00 PM
Arlolra moved this task from Current & Upcoming Work to Testing on the Parsoid board.Jul 30 2021, 10:18 PM
cscott closed this task as Resolved.Nov 5 2021, 4:10 PM

This is done! It's opt-in for now with a clause in the parserTests.txt file, and relies on the extension naming the Parsoid extension as a dependency.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL