Page MenuHomePhabricator
Create Task
Maniphest T254210

ParameterAssertionException "Bad value for parameter $row->rev_timestamp" from RevisionStoreRecord.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error message
Wikimedia\Assert\ParameterAssertionException:
Bad value for parameter $row->rev_timestamp: must be a valid timestamp
Stack Trace
#0 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionStoreRecord.php(73): Wikimedia\Assert\Assert::parameter(boolean, string, string)
#1 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionStoreCacheRecord.php(67): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionStore.php(1518): MediaWiki\Revision\RevisionStoreCacheRecord->__construct(Closure, Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#3 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionStore.php(1360): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#4 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionStore.php(2903): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title, boolean)
#5 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3473): MediaWiki\Revision\RevisionStore->getKnownCurrentRevision(Title)
#6 [internal function]: Parser::statelessFetchRevision(Title, Parser)
#7 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RenderedRevision.php(391): call_user_func(array, Title, Parser)
#8 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/ParserOptions.php(841): MediaWiki\Revision\RenderedRevision->MediaWiki\Revision\{closure}(Title, Parser)
#9 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3440): ParserOptions->{closure}(Title, Parser)
#10 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3409): Parser->fetchCurrentRevisionRecordOfTitle(Title)
#11 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3576): Parser->fetchCurrentRevisionOfTitle(Title)
#12 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3501): Parser->statelessFetchTemplate(Title, Parser)
#13 /srv/mediawiki/php-1.35.0-wmf.34/extensions/Scribunto/includes/common/ScribuntoEngineBase.php(167): Parser->fetchTemplateAndTitle(Title)
#14 /srv/mediawiki/php-1.35.0-wmf.34/extensions/Scribunto/includes/common/Hooks.php(110): ScribuntoEngineBase->fetchModuleFromParser(Title)
#15 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3317): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#16 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3021): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#17 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#18 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(3199): PPFrame_Hash->expand(PPNode_Hash_Tree)
#19 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPFrame_Hash)
#20 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(2862): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#21 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(1548): Parser->replaceVariables(string)
#22 /srv/mediawiki/php-1.35.0-wmf.34/includes/parser/Parser.php(635): Parser->internalParse(string)
#23 /srv/mediawiki/php-1.35.0-wmf.34/includes/content/WikitextContent.php(368): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#24 /srv/mediawiki/php-1.35.0-wmf.34/includes/content/AbstractContent.php(565): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#25 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RenderedRevision.php(267): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#26 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RenderedRevision.php(236): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#27 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#28 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#29 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#30 /srv/mediawiki/php-1.35.0-wmf.34/includes/Revision/RenderedRevision.php(198): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#31 /srv/mediawiki/php-1.35.0-wmf.34/includes/filerepo/file/LocalFile.php(2196): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#32 /srv/mediawiki/php-1.35.0-wmf.34/extensions/CommonsMetadata/src/DataCollector.php(290): LocalFile->getDescriptionText(LanguageEn)
#33 /srv/mediawiki/php-1.35.0-wmf.34/extensions/CommonsMetadata/src/DataCollector.php(98): CommonsMetadata\DataCollector->getDescriptionText(LocalFile, LanguageEn)
#34 /srv/mediawiki/php-1.35.0-wmf.34/extensions/CommonsMetadata/src/HookHandler.php(70): CommonsMetadata\DataCollector->collect(array, LocalFile)
#35 /srv/mediawiki/php-1.35.0-wmf.34/includes/HookContainer/HookContainer.php(313): CommonsMetadata\HookHandler::onGetExtendedMetadata(array, LocalFile, RequestContext, boolean, integer)
#36 /srv/mediawiki/php-1.35.0-wmf.34/includes/HookContainer/HookContainer.php(125): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#37 /srv/mediawiki/php-1.35.0-wmf.34/includes/Hooks.php(136): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#38 /srv/mediawiki/php-1.35.0-wmf.34/includes/media/FormatMetadata.php(1710): Hooks::run(string, array)
#39 /srv/mediawiki/php-1.35.0-wmf.34/includes/media/FormatMetadata.php(1627): FormatMetadata->getExtendedMetadataFromHook(LocalFile, array, integer)
#40 /srv/mediawiki/php-1.35.0-wmf.34/includes/api/ApiQueryImageInfo.php(576): FormatMetadata->fetchExtendedMetadata(LocalFile)
#41 /srv/mediawiki/php-1.35.0-wmf.34/includes/api/ApiQueryImageInfo.php(184): ApiQueryImageInfo::getInfo(LocalFile, array, ApiResult, NULL, array)
#42 /srv/mediawiki/php-1.35.0-wmf.34/includes/api/ApiQuery.php(263): ApiQueryImageInfo->execute()
#43 /srv/mediawiki/php-1.35.0-wmf.34/includes/api/ApiMain.php(1583): ApiQuery->execute()
#44 /srv/mediawiki/php-1.35.0-wmf.34/includes/api/ApiMain.php(523): ApiMain->executeAction()
#45 /srv/mediawiki/php-1.35.0-wmf.34/includes/api/ApiMain.php(494): ApiMain->executeActionWithErrorHandling()
#46 /srv/mediawiki/php-1.35.0-wmf.34/api.php(84): ApiMain->execute()
#47 /srv/mediawiki/w/api.php(3): require(string)
Impact

Some pages cannot be viewed due to the Parser being unable to fetch a particular template from RevisionStore.

The above shows that it also affects API queries where that same template or a page using the template is parsed, such as ApiQueryImageInfo and CommonsMetadata.

Notes

The request that encountered this error used a generator which makes it hard to determine exactly which template reportedly has a corrupt revision row.

Details

Request ID
87c2c626-7063-4526-b94b-8975aa7f3a52
Request URL
commonswiki /w/api.php?action=query&generator=allimages&…&prop=imageinfo&…&iiprop=url|user|dimensions|extmetadata&…
SubjectRepoBranchLines +/-
RevisionStoreRecord: Use MWTimestamp::getTimestamp for detailed errorsmediawiki/coremaster+21 -17
Add more data to the rev_timestamp assertion error for debuggingmediawiki/coremaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jun 2 2020, 1:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2020, 1:11 AM
DannyS712 subscribed.Jun 2 2020, 2:21 AM
CCicalese_WMF moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Jun 2 2020, 2:10 PM
• Pchelolo edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jun 2 2020, 5:46 PM
• eprodromou triaged this task as High priority.Jun 2 2020, 8:21 PM
• eprodromou moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.
thcipriani moved this task from Untriaged to May 2020 on the Wikimedia-production-error board.Jun 3 2020, 6:42 PM
• Pchelolo moved this task from Ready (WIP:5) to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Jun 3 2020, 10:07 PM
gerritbot added a comment.Jun 3 2020, 10:50 PM

Change 602186 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Add more data to the rev_timestamp assertion error for debugging

https://gerrit.wikimedia.org/r/602186

gerritbot added a project: Patch-For-Review.Jun 3 2020, 10:50 PM
• Pchelolo claimed this task.Jun 3 2020, 10:51 PM
• Pchelolo moved this task from Doing(WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
• Pchelolo subscribed.

I tried to find the corrupted template, but it appeared to be impossible. The above patch adds more data to the exception so that investigation can continue.

gerritbot added a comment.Jun 4 2020, 3:58 AM

Change 602186 merged by jenkins-bot:
[mediawiki/core@master] Add more data to the rev_timestamp assertion error for debugging

https://gerrit.wikimedia.org/r/602186

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 4 2020, 4:00 AM
DannyS712 removed a project: Patch-For-Review.Jun 4 2020, 4:02 AM
• Pchelolo moved this task from Waiting for Review to Waiting for deployment on the Platform Team Workboards (Clinic Duty Team) board.Jun 4 2020, 4:05 AM
• Pchelolo moved this task from Waiting for deployment to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Jun 10 2020, 6:30 PM
• Pchelolo added a comment.Jun 10 2020, 6:36 PM

Logging enhancement has been deployed. Now on commons wiki we see: Bad value for parameter $row->rev_timestamp: must be a valid timestamp (rev_id=367335663, rev_timestamp=20190920175225)

The rev_timestamp in the database for this revision is indeed 20190920175225

Krinkle added a comment.Jun 10 2020, 10:45 PM

What is invalid about it?

• Pchelolo added a comment.Jun 11 2020, 1:25 AM
In T254210#6213109, @Krinkle wrote:

What is invalid about it?

That is my question as well... I didn't have time to dig into this more yet, but it's very strange.

Krinkle added a comment.Jun 11 2020, 1:49 AM

Numerous samples can be found via https://logstash.wikimedia.org/goto/36bf0b57cfd3e272d7faa17e67620f93.

  • 2020-06-10T17:14:17 mw1285 commonswiki Bad value for parameter $row->rev_timestamp: must be a valid timestamp (rev_id=367335663, rev_timestamp=20190920175225)
  • 2020-06-10T13:44:29 mw1394 commonswiki Bad value for parameter $row->rev_timestamp: must be a valid timestamp (rev_id=375848924, rev_timestamp=20191117041600)

For each of these, I am unable to reproduce the logic (source) it in isolation from the command-line:

RevisionStoreRecord.php
		$timestamp = MWTimestamp::convert( TS_MW, $row->rev_timestamp );
		Assert::parameter(
			is_string( $timestamp ),
			'$row->rev_timestamp',
			"must be a valid timestamp (rev_id={$this->mId}, rev_timestamp={$row->rev_timestamp})"
		);
eval
> var_dump( MWTimestamp::convert( TS_MW, '20190920175225' ) );
string(14) "20190920175225"

I wonder if this could be due to php opcache corruption (ref T253673). For example, if the defition of the TS_MW constant or some other part of wikimedia/timestamp got corrupted, it would likely lead to setTimestamp (internal call from ::convert()) throwing an exception, which ::convert() catches and then returns boolean false for.

• Pchelolo moved this task from Ready (WIP:5) to Later on the Platform Team Workboards (Clinic Duty Team) board.Jun 15 2020, 3:40 PM
daniel subscribed.Sep 10 2020, 4:41 PM
In T254210#6213420, @Krinkle wrote:

I wonder if this could be due to php opcache corruption (ref T253673).

I see six occurrences over 7 days, all from different hosts. If the opcache got corrupted, wouldn't that cause similar errors for many requests on a single host? I'd imagine a lot of stuff would blow up if e.g. the value of TS_MW was messed up...

Krinkle added a comment.Sep 11 2020, 6:20 PM
In T254210#6451241, @daniel wrote:

I see six occurrences over 7 days, all from different hosts. If the opcache got corrupted, wouldn't that cause similar errors for many requests on a single host? I'd imagine a lot of stuff would blow up if e.g. the value of TS_MW was messed up...

No, in my experience opcache corruptions do not tend to behave that way. Virtually all that I've encountered so far are one-off and not seen again for some time until hours/days later, and then likely on a different server. See past examples at T245183, and T224491.

daniel reassigned this task from • Pchelolo to Holger.Sep 22 2020, 3:30 PM
aaron subscribed.Jan 27 2021, 9:21 PM

It would be interesting to see if the rate of occurrence changes after T266055 is deployed.

aaron added a comment.Feb 23 2021, 9:21 PM

I see two places in ConvertibleTimestamp.php that recast generic "Exception" errors into "TimestampException", which would make convert() return false, which could cause this problem.

Daimona subscribed.Mar 8 2021, 2:40 PM
In T254210#6854495, @aaron wrote:

I see two places in ConvertibleTimestamp.php that recast generic "Exception" errors into "TimestampException", which would make convert() return false, which could cause this problem.

Indeed. Also, FWIW I've just tried this on frwiki using the value from https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-2021.03.08?id=9kgJEngBWKe2MTdRm7f2, but I cannot reproduce it. I think it would be useful to log what's causing the TimestampException to be thrown. ConvertibleTimestamp::convert() is essentially swallowing any potentially useful information. However, since that is library code, I think it wouldn't be practical to add a dependency on a logger. Instead, we might add

public static function convertThrow( $style, $ts ) : string {
	$ct = new static( $ts );
	return $ct->getTimestamp( $style );
}

for places (like RevisionStore) that require a valid timestamp, so they don't have to check for false, and we would also preserve detailed information about the error.

Daimona added a project: MediaWiki-libs-Timestamp.Mar 8 2021, 2:40 PM
Daimona added a comment.Mar 8 2021, 2:43 PM

Oh wait but that's already possible:

( new ConvertibleTimestamp() )->getTimestamp()

this can already be used in RevisionStore.

gerritbot added a comment.Mar 8 2021, 2:47 PM

Change 669842 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] RevisionStoreRecord: Use MWTimestamp::getTimestamp for detailed errors

https://gerrit.wikimedia.org/r/669842

gerritbot added a project: Patch-For-Review.Mar 8 2021, 2:47 PM
gerritbot added a comment.Apr 1 2021, 2:06 AM

Change 669842 merged by jenkins-bot:

[mediawiki/core@master] RevisionStoreRecord: Use MWTimestamp::getTimestamp for detailed errors

https://gerrit.wikimedia.org/r/669842

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2021, 2:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Apr 1 2021, 3:00 AM
daniel added a comment.Apr 21 2021, 2:40 PM

Last seen on April 6. Seems fixed, but hard to be sure, the error only occurred one a week or so before.

Daimona added a comment.Apr 21 2021, 2:48 PM
In T254210#7024436, @daniel wrote:

Last seen on April 6. Seems fixed, but hard to be sure, the error only occurred one a week or so before.

The error message would be different now though. It would be an uncaught TimestampException. However, I'm not seeing any TimestampException from RevisionStoreRecord on logstash. Guess we might want to wait a bit more.

• Pchelolo added a comment.Jun 21 2021, 3:56 AM

Found some:

exception.previous.message:

The maximum execution time of 60 seconds was exceeded

exception.previous.trace:

from /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/request-timeout/src/Detail/ExcimerTimerWrapper.php(97)
#0 /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/request-timeout/src/Detail/ExcimerTimerWrapper.php(72): Wikimedia\RequestTimeout\Detail\ExcimerTimerWrapper->onTimeout(integer)
#1 /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(251): Wikimedia\RequestTimeout\Detail\ExcimerTimerWrapper->Wikimedia\RequestTimeout\Detail\{closure}(integer)
#2 /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(165): Wikimedia\Timestamp\ConvertibleTimestamp->setTimestamp(string)
#3 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStoreRecord.php(73): Wikimedia\Timestamp\ConvertibleTimestamp->__construct(string)
#4 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStoreCacheRecord.php(67): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, MediaWiki\User\UserIdentityValue, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#5 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStore.php(1753): MediaWiki\Revision\RevisionStoreCacheRecord->__construct(Closure, Title, MediaWiki\User\UserIdentityValue, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#6 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStore.php(1559): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#7 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStore.php(3226): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title, boolean)

exception.trace:

from /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(254)
#0 /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(165): Wikimedia\Timestamp\ConvertibleTimestamp->setTimestamp(string)
#1 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStoreRecord.php(73): Wikimedia\Timestamp\ConvertibleTimestamp->__construct(string)
#2 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStoreCacheRecord.php(67): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, MediaWiki\User\UserIdentityValue, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#3 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStore.php(1753): MediaWiki\Revision\RevisionStoreCacheRecord->__construct(Closure, Title, MediaWiki\User\UserIdentityValue, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#4 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStore.php(1559): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#5 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStore.php(3226): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title, boolean)
Krinkle added a comment.Jul 12 2021, 7:18 PM

Still seen at https://logstash.wikimedia.org/goto/6717085ed08cc04ab171a3afa112598e

Logstash mediawiki-errors query exception.trace:(RevisionStoreRecord.php) AND message:"TimestampException"

Wikimedia\Timestamp\TimestampException: Wikimedia\Timestamp\ConvertibleTimestamp::setTimestamp: Invalid timestamp format.
from /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(254)
#0 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(165): Wikimedia\Timestamp\ConvertibleTimestamp->setTimestamp(string)
#1 /srv/mediawiki/php-1.37.0-wmf.12/includes/Revision/RevisionStoreRecord.php(73): Wikimedia\Timestamp\ConvertibleTimestamp->__construct(string)
#2 /srv/mediawiki/php-1.37.0-wmf.12/includes/Revision/RevisionStoreCacheRecord.php(67): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, MediaWiki\User\UserIdentityValue, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#3 /srv/mediawiki/php-1.37.0-wmf.12/includes/Revision/RevisionStore.php(1752): MediaWiki\Revision\RevisionStoreCacheRecord->__construct(Closure, Title, MediaWiki\User\UserIdentityValue, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#4 /srv/mediawiki/php-1.37.0-wmf.12/includes/Revision/RevisionStore.php(1558): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#5 /srv/mediawiki/php-1.37.0-wmf.12/includes/Revision/RevisionStore.php(2898): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title, boolean)
#6 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3543): MediaWiki\Revision\RevisionStore->getKnownCurrentRevision(Title)
#7 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3496): Parser->statelessFetchRevisionRecord(Title, Parser)
#8 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3647): Parser->fetchCurrentRevisionRecordOfTitle(Title)
#9 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3559): Parser->statelessFetchTemplate(Title, Parser)
#10 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3453): Parser->fetchTemplateAndTitle(Title)
#11 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3194): Parser->getTemplateDom(Title)
#12 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPFrame_Hash)
#13 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(2916): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#14 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(918): Parser->replaceVariables(string, PPFrame_Hash)
#15 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(4827): Parser->preprocess(string, Title, ParserOptions)
#16 /srv/mediawiki/php-1.37.0-wmf.12/includes/cache/MessageCache.php(1261): Parser->transformMsg(string, ParserOptions, Title)
#17 /srv/mediawiki/php-1.37.0-wmf.12/includes/language/Message.php(1381): MessageCache->transform(string, boolean, Language, NULL)
#18 /srv/mediawiki/php-1.37.0-wmf.12/includes/language/Message.php(948): Message->transformText(string)
#19 /srv/mediawiki/php-1.37.0-wmf.12/includes/language/Message.php(1008): Message->format(string)
#20 /srv/mediawiki/php-1.37.0-wmf.12/extensions/ParserFunctions/includes/ExprError.php(49): Message->text()
#21 /srv/mediawiki/php-1.37.0-wmf.12/extensions/ParserFunctions/includes/ParserFunctions.php(72): MediaWiki\Extensions\ParserFunctions\ExprError->getUserFriendlyMessage()
#22 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3393): MediaWiki\Extensions\ParserFunctions\ParserFunctions::expr(Parser, string)
#23 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3078): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#24 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#25 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(2992): PPFrame_Hash->expand(PPNode_Hash_Tree)
#26 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#27 /srv/mediawiki/php-1.37.0-wmf.12/extensions/ParserFunctions/includes/ParserFunctions.php(123): PPFrame_Hash->expand(PPNode_Hash_Tree)
#28 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3393): MediaWiki\Extensions\ParserFunctions\ParserFunctions::if(Parser, PPTemplateFrame_Hash, array)
#29 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3078): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#30 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#31 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(3267): PPFrame_Hash->expand(PPNode_Hash_Tree)
#32 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPFrame_Hash)
#33 /srv/mediawiki/php-1.37.0-wmf.12/includes/parser/Parser.php(2916): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#34 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/extension/src/Config/DataAccess.php(296): Parser->replaceVariables(string)
#35 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1132): MWParsoid\Config\DataAccess->preprocessWikitext(MWParsoid\Config\PageConfig, string)
#36 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1508): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->fetchExpandedTpl(string)
#37 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1571): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->onTemplate(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#38 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(202): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#39 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(118): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#40 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(168): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#41 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(166): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#42 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/HTML5TreeBuilder.php(416): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#43 [internal function]: Wikimedia\Parsoid\Wt2Html\HTML5TreeBuilder->processChunkily(string, array)
#44 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(916): Generator->current()
#45 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(178): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#46 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(307): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#47 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Core/WikitextContentModelHandler.php(106): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#48 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Parsoid.php(161): Wikimedia\Parsoid\Core\WikitextContentModelHandler->toDOM(Wikimedia\Parsoid\Config\Env)
#49 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Parsoid.php(193): Wikimedia\Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)
#50 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php(588): Wikimedia\Parsoid\Parsoid->wikitext2html(MWParsoid\Config\PageConfig, array, NULL)
#51 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(88): MWParsoid\Rest\Handler\ParsoidHandler->wt2html(MWParsoid\Config\PageConfig, array)
#52 /srv/mediawiki/php-1.37.0-wmf.12/includes/Rest/Router.php(395): MWParsoid\Rest\Handler\PageHandler->execute()
#53 /srv/mediawiki/php-1.37.0-wmf.12/includes/Rest/Router.php(322): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#54 /srv/mediawiki/php-1.37.0-wmf.12/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#55 /srv/mediawiki/php-1.37.0-wmf.12/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#56 /srv/mediawiki/php-1.37.0-wmf.12/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#57 /srv/mediawiki/w/rest.php(3): require(string)
#58 {main}

@duesen Is this the detail you were looking for? It seems to still be quite generic, apart from telling us:

  • ConvertibleTimestamp->__construct(string) and
  • RevisionStoreRecord->__construct(Title, …\UserIdentityValue, CommentStoreComment, stdClass, …\RevisionSlots, bool)
Daimona added a comment.Jul 13 2021, 1:05 PM

I think we now know the exact line of code that is failing, but OTOH, we don't know what value(s) it's failing on. I think ideally, this line should also pass $format and $strtime to the exception constructor.

I also believe that there's another important point: all of these exceptions seem to happen together with a timeout, and they have an associated exception.previous whose trace ends with:

from /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/request-timeout/src/Detail/ExcimerTimerWrapper.php(97)
#0 /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/request-timeout/src/Detail/ExcimerTimerWrapper.php(72): Wikimedia\RequestTimeout\Detail\ExcimerTimerWrapper->onTimeout(integer)
#1 /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(251): Wikimedia\RequestTimeout\Detail\ExcimerTimerWrapper->Wikimedia\RequestTimeout\Detail\{closure}(integer)
#2 /srv/mediawiki/php-1.37.0-wmf.9/vendor/wikimedia/timestamp/src/ConvertibleTimestamp.php(165): Wikimedia\Timestamp\ConvertibleTimestamp->setTimestamp(string)
#3 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStoreRecord.php(73): Wikimedia\Timestamp\ConvertibleTimestamp->__construct(string)
#4 /srv/mediawiki/php-1.37.0-wmf.9/includes/Revision/RevisionStoreCacheRecord.php(67): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, MediaWiki\User\UserIdentityValue, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)

Still haven't looked into that though.

Krinkle removed Holger as the assignee of this task.Oct 10 2021, 12:04 AM
Krinkle removed projects: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).
Krinkle moved this task from Later to Inbox on the Platform Team Workboards (Clinic Duty Team) board.
Krinkle added subscribers: • holger.knust, Holger.

Moving back for re-triage given @holger.knust is no longer active.

Krinkle moved this task from May 2020 to Older on the Wikimedia-production-error board.Oct 10 2021, 12:04 AM
Arlolra mentioned this in T293568: PHP Notice: Undefined offset in wikimedia/remex-html when rendering rest.php error page.Oct 21 2021, 10:15 PM
daniel added a comment.Nov 22 2021, 1:57 PM

Tim recently worked on a PHP bug where the timeout handler would leave a dangling pointer, causing memory corruption. This may be fallout from that issue.

• tstarling subscribed.Nov 24 2021, 12:04 AM

Any weird data corruption issue which occurs when handling a timeout should be closed as a duplicate of T293568. It's unclear to me whether this bug qualifies since the original error was not inside the exception handler. But T254210#7164506 would certainly qualify.

Krinkle moved this task from Untriaged to Revision on the MediaWiki-Core-Revision-backend board.Mar 2 2022, 8:35 PM
Krinkle edited projects, added Unstewarded-production-error; removed Platform Team Workboards (Clinic Duty Team).Aug 18 2023, 7:30 PM
Krinkle unsubscribed.
Umherirrender closed this task as Resolved.Oct 2 2023, 6:45 PM
Umherirrender subscribed.

The stack trace from task description cannot longer occur as the code was changed for better debugging.
The debugging shows up another place, which gets now handled in T345701: Wikimedia\Timestamp\TimestampException: Wikimedia\Timestamp\ConvertibleTimestamp::setTimestamp: Invalid timestamp format., so this task can be treated as fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL