Description

Translate extension should use the SidebarBeforeOutput hook (instead of BaseTemplateToolbox hook) to add sidebar element to the toolbox section.

Details

	Subject	Repo	Branch	Lines +/-
	Use SidebarBeforeOutput hook to add toolbox items	mediawiki/extensions/Translate	master	+56 -19

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Ammarpad	T254431 Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook
Resolved	Ammarpad	T254433 Collection should not use SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook
Resolved	Ammarpad	T253809 [EPIC] Deprecate the BaseTemplate hooks
Resolved	Ammarpad	T253416 Deprecate BaseTemplateToolbox hook
Resolved	Mainframe98	T254218 Translate should use the SidebarBeforeOutput hook

Event Timeline

Ammarpad created this task.Jun 2 2020, 7:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2020, 7:02 AM

Ammarpad added a parent task: T253416: Deprecate BaseTemplateToolbox hook.Jun 2 2020, 7:03 AM

Ammarpad added a subscriber: Jdlrobson.

Ammarpad added projects: MediaWiki-User-Interface, MediaWiki-Core-Skin-Architecture.Jun 2 2020, 7:22 AM

@Ammarpad: If this is about the Translate extension code then it should be tagged as such?

Note that the Translate extension is part of the MediaWiki Language Extension Bundle, and has a strict compatibility policy. The extension must stay compatible with 1.33.

In T254218#6183924, @Aklapper wrote:

@Ammarpad: If this is about the Translate extension code then it should be tagged as such?

Yes, it should. Thanks for correcting it.

Change 601654 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/extensions/Translate@master] Use SidebarBeforeOutput hook to add toolbox items

https://gerrit.wikimedia.org/r/601654

gerritbot added a project: Patch-For-Review.Jun 2 2020, 8:49 AM

Jdlrobson added a project: MW-1.35-release.Jun 2 2020, 5:35 PM

Jdlrobson triaged this task as High priority.Jun 5 2020, 8:51 PM

Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.Jun 8 2020, 11:08 PM

Jdlrobson moved this task from Backlog to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.

Change 601654 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Use SidebarBeforeOutput hook to add toolbox items

https://gerrit.wikimedia.org/r/601654

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 9 2020, 2:00 AM

Jdlrobson closed this task as Resolved.Jun 9 2020, 2:08 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 2:10 AM