Sidebar should allow for different states for logged-in and anonymous users
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Background

Follow-up from T246419: Build collapsible sidebar and sidebar button .

Use cases

As a a reader, I would like my sidebar to be collapsed by default so that I can focus on the content of a page
As an editor, I would like my sidebar to be open by default so that I can easily go to pages related to my workflow, such as recent changes

Acceptance criteria

Allow the sidebar default to vary based on logged-in status

NOTE: the initial state for all uses will be for the sidebar to be OPEN by default. The eventual state will be for the sidebar to be OPEN by default for logged-in users and CLOSED by default for anonymous uses.

Details

	Project	Branch	Lines +/-	Subject
	operations/mediawiki-config	master	+8 -0	Add defaults for initial state for sidebar.
	mediawiki/skins/Vector	master	+38 -1	Select initial side bar visibility depends on user login state and defaults

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T16501 A way to hide the sidebar providing a "fullscreen" view
Resolved	ovasileva	T247032 [EPIC] Build collapsible sidebar and deploy to all test wikis
Resolved	Jdlrobson	T251903 Translate's NaviToggle should be hidden in modern Vector
Resolved	ovasileva	T246419 Build collapsible sidebar and sidebar button
Resolved	Peter.ovchyn	T254230 Sidebar should allow for different states for logged-in and anonymous users

Event Timeline

ovasileva created this task.Jun 2 2020, 10:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2020, 10:36 AM

ovasileva triaged this task as High priority.Jun 2 2020, 10:37 AM

ovasileva mentioned this in T246419: Build collapsible sidebar and sidebar button .

ovasileva set the point value for this task to 2.Jun 3 2020, 4:47 PM

ovasileva moved this task from Needs Analysis to Ready for Development on the Readers-Web-Backlog (Kanbanana-2019-20-Q4) board.

Notes:

The visibility state is currently hardcoded.
Add a configuration parameter and set the appropriate default in skin.json and mediawiki-config.
Integrate with FeatureManager or check the configuration directly.
Caching is not part of this task.
This has possible overlap with T246427 in terms of how that initial default value is set. Remember that the default is blasted away as soon as the sidebar is toggled.

Peter.ovchyn claimed this task.Jul 3 2020, 10:50 AM

Peter.ovchyn moved this task from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q4) board.

Change 609979 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/skins/Vector@master] Select initial side bar visibility depends on user login state and defaults.

https://gerrit.wikimedia.org/r/609979

gerritbot added a project: Patch-For-Review.Jul 7 2020, 8:59 AM

Peter.ovchyn moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q4) board.Jul 7 2020, 9:56 AM

Change 610069 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[operations/mediawiki-config@master] Add defaults for initial state for sidebar.

https://gerrit.wikimedia.org/r/610069

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q4) board.Jul 7 2020, 5:55 PM

Change 609979 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Select initial side bar visibility depends on user login state and defaults

https://gerrit.wikimedia.org/r/609979

Not sure how to QA this one in current state easily. Possibly a developer can verify as part of sign off?

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 7 2020, 8:00 PM

MBinder_WMF edited projects, added Readers-Web-Backlog (Kanbanana-FY-2020-21); removed Readers-Web-Backlog (Kanbanana-2019-20-Q4).Jul 9 2020, 5:13 PM

MBinder_WMF moved this task from Needs Analysis to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.Jul 9 2020, 5:13 PM

nray claimed this task.Jul 13 2020, 5:11 PM

nray added a subscriber: Peter.ovchyn.

Tested VectorDefaultSidebarVisibleForAuthorisedUser flag (true/false) and VectorDefaultSidebarVisibleForAnonymousUserflag (true/false). Both seem to be working as they should!

nray closed this task as Resolved.Jul 16 2020, 11:19 PM

nray updated the task description. (Show Details)

nray reassigned this task from nray to Peter.ovchyn.Jul 16 2020, 11:21 PM

nray added a subscriber: nray.

Jdlrobson mentioned this in T258588: Sidebar collapsed by default on desktop improvements.Jul 24 2020, 6:51 PM

Sidebar should allow for different states for logged-in and anonymous usersClosed, ResolvedPublic2 Estimated Story PointsActions