LiquidThreads should use onGetNewMessagesAlert - SkinTemplateOutputPageBeforeExec hook is to be deprecated
Closed, ResolvedPublic
Actions

Description

LiquidThreads is apparently still enabled on several wikis

('enwikinews' => true, // Per T23956 -- Andrew 2009-02-09
        'enwiktionary' => true, // T25417 -- ariel 2010-16-05
        'huwiki' => true, // T24909 -- Andrew 2010-09-06
        'ptwikibooks' => true, // T26143 -- Andrew 2010-08-16
        'svwikisource' => true, // T25220 -- Andrew 2010-08-28
)

It uses the soon to be deprecated SkinTemplateOutputPageBeforeExec hook.

https://gerrit.wikimedia.org/g/mediawiki/extensions/LiquidThreads/+/a63a1fa2ed72a7f65bda3b922a9b68522911ffd8/extension.json#210

Developer notes

The hook is used to set new talk page messages.
https://gerrit.wikimedia.org/g/mediawiki/extensions/LiquidThreads/+/a63a1fa2ed72a7f65bda3b922a9b68522911ffd8/classes/Hooks.php#80

It should instead use the ''onGetNewMessagesAlert'' hook.

Details

	Subject	Repo	Branch	Lines +/-
	LiquidThreads: Use GetNewMessagesAlert hook	mediawiki/extensions/LiquidThreads	master	+25 -24

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T140664 Achieve predictable MediaWiki routing and cacheable skin data
Resolved	Jdlrobson	T253813 [EPIC] Deprecate the SkinTemplate hooks and simplify the skin<->extension contract.
Resolved	None	T60137 Deprecate the SkinTemplateOutputPageBeforeExec hook
Resolved	Ammarpad	T254297 LiquidThreads should use onGetNewMessagesAlert - SkinTemplateOutputPageBeforeExec hook is to be deprecated

Event Timeline

Jdlrobson created this task.Jun 2 2020, 11:25 PM

Jdlrobson mentioned this in T60137: Deprecate the SkinTemplateOutputPageBeforeExec hook.Jun 2 2020, 11:44 PM

Jdlrobson moved this task from Backlog to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.Jun 2 2020, 11:53 PM

Jdlrobson triaged this task as Medium priority.Jun 5 2020, 9:56 PM

Jdlrobson moved this task from Inbox to OKR Backlog on the User-Jdlrobson board.Jun 9 2020, 11:33 PM

Jdlrobson moved this task from OKR Backlog to Next up on the User-Jdlrobson board.Jun 9 2020, 11:42 PM

• ppelberg subscribed.Jun 11 2020, 1:11 AM

Alternatively let's decommission this T255175

Krinkle unsubscribed.Jun 11 2020, 5:41 PM

Krinkle removed projects: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), MW-1.35-release, Technical-Debt (Deprecation process).Jun 11 2020, 5:46 PM

Krinkle removed subscribers: DanielFriesen, • GWicke, ashley and 2 others.

Re-adding "MW-1.35-release". The reason its coming up is T60137 is targeting that release.

On the other hand, I guess we could do a silent deprecation and leave the LiquidThreads code untouched (in which case feel free to remove the tag).

In T254297#6216711, @Jdlrobson wrote:

Re-adding "MW-1.35-release". The reason its coming up is T60137 is targeting that release.

On the other hand, I guess we could do a silent deprecation and leave the LiquidThreads code untouched (in which case feel free to remove the tag).

I think that will just shift the technical debt with little gain. Several extensions have been fixed and only LiquidThreads remains. Probably it's better to fix LT now and hard deprecate the hook

Bumping to high as this is the last remaining extension blocking deprecation of the SkinTemplateOutputPageBeforeExec hook

It seems we have missed another, MediaWiki-extensions-FeaturedFeeds is using it and is deployed in production. Tracked in T255380. (Search result)

Ammarpad claimed this task.Jun 14 2020, 7:42 PM

Change 605432 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/LiquidThreads@master] LiquidThreads: Use GetNewMessagesAlert hook

https://gerrit.wikimedia.org/r/605432

gerritbot added a project: Patch-For-Review.Jun 14 2020, 11:59 PM

Change 605432 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] LiquidThreads: Use GetNewMessagesAlert hook

https://gerrit.wikimedia.org/r/605432

Ammarpad closed this task as Resolved.Jun 15 2020, 5:29 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 15 2020, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2020, 6:10 PM