Page MenuHomePhabricator
Create Task
Maniphest T254349

A default install of MW+VE still shows VE in beta features and defaults the user option to disabled
Closed, ResolvedPublic
Actions

Assigned To
ppelberg
Authored By
Esanders
Jun 3 2020, 1:41 PM
Tags
Referenced Files
F32379732: Screen Shot 2020-10-09 at 1.05.12 PM.png
Oct 9 2020, 8:07 PM
F32379745: Screen Shot 2020-10-09 at 1.05.16 PM.png
Oct 9 2020, 8:07 PM
F32370446: Screen Shot 2020-10-01 at 4.11.57 PM.png
Oct 1 2020, 11:14 PM
Subscribers
Aklapper
Esanders
JTannerWMF
matmarex
ppelberg

Description

In T50666 we decided that WMF wikis that enable VE should not show it in beta features as well. This was done with a hack by setting $wgHiddenPrefs[] = 'visualeditor-enable';. This means that on third party wikis VE still shows up as a beta feature. This is not necessary as there is already a preference in 'Editing' to disable VE.

Note that some wikis still require VE to be a beta feature, rather than an editing preference, e.g. pl.wiktionary.

To a similar end we should change DefaultUserOptions['visualeditor-enable'] to true.

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+0 -2Drop wgHiddenPrefs hack for VE Beta Feature
operations/mediawiki-configmaster+4 -1Prepare for VE's new Beta Feature preference
mediawiki/vagrantmaster+0 -1Remove DefaultUserOption for visualeditor-enable
mediawiki/extensions/VisualEditormaster+21 -15Create config option for making VE a BetaFeature, off by default
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jun 3 2020, 1:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2020, 1:41 PM
Esanders added a comment.Aug 18 2020, 12:28 PM

visualeditor-enable was set to true in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/610157

gerritbot added a comment.Aug 18 2020, 2:11 PM

Change 620951 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Create preference for making VE a Beta Feature

https://gerrit.wikimedia.org/r/620951

gerritbot added a project: Patch-For-Review.Aug 18 2020, 2:11 PM
gerritbot added a comment.Aug 18 2020, 2:15 PM

Change 620953 had a related patch set uploaded (by Esanders; owner: Esanders):
[operations/mediawiki-config@master] Use VE's new Beta Feature preference instead of wgHiddenPrefs

https://gerrit.wikimedia.org/r/620953

gerritbot added a comment.Aug 18 2020, 2:21 PM

Change 620958 had a related patch set uploaded (by Esanders; owner: Esanders):
[operations/mediawiki-config@master] Drop wgHiddenPrefs hack for VE Beta Feature

https://gerrit.wikimedia.org/r/620958

gerritbot added a comment.Aug 18 2020, 2:36 PM

Change 620987 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/vagrant@master] Remove DefaultUserOption for visualeditor-enable

https://gerrit.wikimedia.org/r/620987

gerritbot added a comment.Aug 18 2020, 4:15 PM

Change 620951 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Create config option for making VE a BetaFeature, off by default

https://gerrit.wikimedia.org/r/620951

gerritbot added a comment.Aug 18 2020, 5:39 PM

Change 620987 merged by jenkins-bot:
[mediawiki/vagrant@master] Remove DefaultUserOption for visualeditor-enable

https://gerrit.wikimedia.org/r/620987

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 19 2020, 5:50 AM
gerritbot added a comment.Aug 26 2020, 5:08 PM

Change 620953 merged by jenkins-bot:
[operations/mediawiki-config@master] Prepare for VE's new Beta Feature preference

https://gerrit.wikimedia.org/r/620953

Stashbot added a comment.Aug 26 2020, 5:12 PM

Mentioned in SAL (#wikimedia-operations) [2020-08-26T17:12:41Z] <jforrester@deploy1001> Synchronized wmf-config/CommonSettings.php: T254349 Set wgVisualEditorEnableBetaFeature true on wikis that need it (duration: 01m 03s)

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Aug 27 2020, 4:41 PM
ppelberg added a project: Editing QA.Aug 27 2020, 4:45 PM
ppelberg added a subscriber: ppelberg.

Testing instructions

  • To confirm this patch has been implemented as we expect it to be, the following should be true:
    • Visit one wiki from this list [i]; ensure Visual Editor appears as a Beta Feature
    • Visit Arabic Wikipedia (ar.wiki); ensure Visual Editor does NOT appears as a Beta Feature

i. https://noc.wikimedia.org/conf/highlight.php?file=dblists/visualeditor-nondefault.dblist

ppelberg added a comment.Oct 1 2020, 11:14 PM
In T254349#6416598, @ppelberg wrote:

Testing instructions

  • To confirm this patch has been implemented as we expect it to be, the following should be true:
    • Visit one wiki from this list [i]; ensure Visual Editor appears as a Beta Feature

VE is showing as a Beta Feature en.wikibooks, but it doesn't seem like it can be enabled. [i] I suspect this is expected because VE not being enabled is the result of an unrelated decision/issue.

@Esanders, can you confirm the behavior I am describing above is expected.

  • Visit Arabic Wikipedia (ar.wiki); ensure Visual Editor does NOT appears as a Beta Feature

As expected, VE does not appear here: https://ar.wikipedia.org/wiki/%D8%AE%D8%A7%D8%B5:%D8%AA%D9%81%D8%B6%D9%8A%D9%84%D8%A7%D8%AA#mw-prefsection-betafeatures.

i.

Screen Shot 2020-10-01 at 4.11.57 PM.png (554×1 px, 72 KB)

ppelberg edited projects, added Skipped QA, Editing-team (Kanban Board); removed Editing QA.Oct 1 2020, 11:14 PM
ppelberg moved this task from Incoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
Esanders added a comment.Oct 4 2020, 11:05 AM

This patch should not change any behaviour on WMF wikis, it just cleaned up our config and changed the defaults for third party installs.

The testing instructions look correct.

VE is showing as a Beta Feature en.wikibooks, but it doesn't seem like it can be enabled. [i] I suspect this is expected because VE not being enabled is the result of an unrelated decision/issue.

Agreed. It’s enabled for me. BFs should only show as disabled when they are missing some dependency (eg JS is disabled).

JTannerWMF added a subscriber: JTannerWMF.Oct 7 2020, 5:11 PM

@ppelberg to check the following:

  1. If he has VE enabled in Global Preferences
  2. Whether he has all Beta Features enabled by default
ppelberg added a comment.Oct 9 2020, 8:07 PM
  • @Esanders do the answers I've provided below confirm that this patch does not change any behavior on WMF wikis and the experience I described in T254349#6510886 as result of me having VE enabled in Global preferences?
In T254349#6526280, @JTannerWMF wrote:

@ppelberg to check the following:

  1. If he has VE enabled in Global Preferences

I do seem to have VE enabled in Global preferences [i]

Screen Shot 2020-10-09 at 1.05.16 PM.png (1×1 px, 245 KB)

  1. Whether he has all Beta Features enabled by default

I do not seem to have this functionality enabled in Global preferences [i]:

Screen Shot 2020-10-09 at 1.05.12 PM.png (1×1 px, 165 KB)

i. https://en.wikibooks.org/wiki/Special:GlobalPreferences#mw-prefsection-betafeatures

Esanders added a comment.Oct 14 2020, 4:22 PM

Yes. It looks like the VE option was disabled on a specific wiki because you had it enabled as a global preference.

Esanders moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 14 2020, 4:22 PM
ppelberg closed this task as Resolved.Oct 16 2020, 12:41 AM
ppelberg claimed this task.
In T254349#6543064, @Esanders wrote:

Yes. It looks like the VE option was disabled on a specific wiki because you had it enabled as a global preference.

Roger that. Thank you for confirming.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 16 2020, 12:41 AM
gerritbot added a comment.Oct 19 2020, 6:04 PM

Change 620958 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop wgHiddenPrefs hack for VE Beta Feature

https://gerrit.wikimedia.org/r/620958

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2020, 6:10 PM
Stashbot added a comment.Oct 19 2020, 6:10 PM

Mentioned in SAL (#wikimedia-operations) [2020-10-19T18:10:56Z] <catrope@deploy1001> Synchronized wmf-config/CommonSettings.php: Drop wgHiddenPrefs hack for VE beta feature (T254349) (duration: 00m 56s)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL