Page MenuHomePhabricator

A default install of MW+VE still shows VE in beta features and defaults the user option to disabled
Closed, ResolvedPublic

Description

In T50666 we decided that WMF wikis that enable VE should not show it in beta features as well. This was done with a hack by setting $wgHiddenPrefs[] = 'visualeditor-enable';. This means that on third party wikis VE still shows up as a beta feature. This is not necessary as there is already a preference in 'Editing' to disable VE.

Note that some wikis still require VE to be a beta feature, rather than an editing preference, e.g. pl.wiktionary.

To a similar end we should change DefaultUserOptions['visualeditor-enable'] to true.

Event Timeline

Change 620951 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Create preference for making VE a Beta Feature

https://gerrit.wikimedia.org/r/620951

Change 620953 had a related patch set uploaded (by Esanders; owner: Esanders):
[operations/mediawiki-config@master] Use VE's new Beta Feature preference instead of wgHiddenPrefs

https://gerrit.wikimedia.org/r/620953

Change 620958 had a related patch set uploaded (by Esanders; owner: Esanders):
[operations/mediawiki-config@master] Drop wgHiddenPrefs hack for VE Beta Feature

https://gerrit.wikimedia.org/r/620958

Change 620987 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/vagrant@master] Remove DefaultUserOption for visualeditor-enable

https://gerrit.wikimedia.org/r/620987

Change 620951 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Create config option for making VE a BetaFeature, off by default

https://gerrit.wikimedia.org/r/620951

Change 620987 merged by jenkins-bot:
[mediawiki/vagrant@master] Remove DefaultUserOption for visualeditor-enable

https://gerrit.wikimedia.org/r/620987

Change 620953 merged by jenkins-bot:
[operations/mediawiki-config@master] Prepare for VE's new Beta Feature preference

https://gerrit.wikimedia.org/r/620953

Mentioned in SAL (#wikimedia-operations) [2020-08-26T17:12:41Z] <jforrester@deploy1001> Synchronized wmf-config/CommonSettings.php: T254349 Set wgVisualEditorEnableBetaFeature true on wikis that need it (duration: 01m 03s)

ppelberg added a subscriber: ppelberg.

Testing instructions

  • To confirm this patch has been implemented as we expect it to be, the following should be true:
    • Visit one wiki from this list [i]; ensure Visual Editor appears as a Beta Feature
    • Visit Arabic Wikipedia (ar.wiki); ensure Visual Editor does NOT appears as a Beta Feature

i. https://noc.wikimedia.org/conf/highlight.php?file=dblists/visualeditor-nondefault.dblist

Testing instructions

  • To confirm this patch has been implemented as we expect it to be, the following should be true:
    • Visit one wiki from this list [i]; ensure Visual Editor appears as a Beta Feature

VE is showing as a Beta Feature en.wikibooks, but it doesn't seem like it can be enabled. [i] I suspect this is expected because VE not being enabled is the result of an unrelated decision/issue.

@Esanders, can you confirm the behavior I am describing above is expected.

  • Visit Arabic Wikipedia (ar.wiki); ensure Visual Editor does NOT appears as a Beta Feature

As expected, VE does not appear here: https://ar.wikipedia.org/wiki/%D8%AE%D8%A7%D8%B5:%D8%AA%D9%81%D8%B6%D9%8A%D9%84%D8%A7%D8%AA#mw-prefsection-betafeatures.


i.

This patch should not change any behaviour on WMF wikis, it just cleaned up our config and changed the defaults for third party installs.

The testing instructions look correct.

VE is showing as a Beta Feature en.wikibooks, but it doesn't seem like it can be enabled. [i] I suspect this is expected because VE not being enabled is the result of an unrelated decision/issue.

Agreed. It’s enabled for me. BFs should only show as disabled when they are missing some dependency (eg JS is disabled).

@ppelberg to check the following:

  1. If he has VE enabled in Global Preferences
  2. Whether he has all Beta Features enabled by default
  • @Esanders do the answers I've provided below confirm that this patch does not change any behavior on WMF wikis and the experience I described in T254349#6510886 as result of me having VE enabled in Global preferences?

@ppelberg to check the following:

  1. If he has VE enabled in Global Preferences

I do seem to have VE enabled in Global preferences [i]

  1. Whether he has all Beta Features enabled by default

I do not seem to have this functionality enabled in Global preferences [i]:


i. https://en.wikibooks.org/wiki/Special:GlobalPreferences#mw-prefsection-betafeatures

Yes. It looks like the VE option was disabled on a specific wiki because you had it enabled as a global preference.

ppelberg claimed this task.

Yes. It looks like the VE option was disabled on a specific wiki because you had it enabled as a global preference.

Roger that. Thank you for confirming.

Change 620958 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop wgHiddenPrefs hack for VE Beta Feature

https://gerrit.wikimedia.org/r/620958

Mentioned in SAL (#wikimedia-operations) [2020-10-19T18:10:56Z] <catrope@deploy1001> Synchronized wmf-config/CommonSettings.php: Drop wgHiddenPrefs hack for VE beta feature (T254349) (duration: 00m 56s)