Page MenuHomePhabricator
Create Task
Maniphest T254393

Add CI tests for labs/tools/zppixbot
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

It would be a lot safer if CI checked & merged labs/tools/zppixbot as it prevents accidental submits and helps check syntax

These should run html+css syntax checks on our code and if CR+2 gate-and-submit the change.

Details

SubjectRepoBranchLines +/-
Switch to CI-Only push accesslabs/tools/ZppixBotrefs/meta/config+1 -1
Add htmlllint to lint the HTML fileslabs/tools/ZppixBotmaster+1 K -1
Add stylelint to lint the css filelabs/tools/ZppixBotmaster+2 K -3
Add CI for labs/tools/ZppixBotintegration/configmaster+11 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedMacFan4000T233993 Improve & Update ZppixBot docs
 ResolvedhasharT254393 Add CI tests for labs/tools/zppixbot

Event Timeline

RhinosF1 created this task.Jun 3 2020, 7:50 PM
Restricted Application added subscribers: MacFan4000, Zppix, Aklapper. · View Herald TranscriptJun 3 2020, 7:50 PM
RhinosF1 added a comment.Jun 3 2020, 7:51 PM

Once this is added, please revoke submit for non-CI.

gerritbot added a comment.Jun 4 2020, 8:58 AM

Change 602292 had a related patch set uploaded (by Hashar; owner: Hashar):
[labs/tools/ZppixBot@master] Add stylelint to lint the css file

https://gerrit.wikimedia.org/r/602292

gerritbot added a project: Patch-For-Review.Jun 4 2020, 8:58 AM
gerritbot added a comment.Jun 4 2020, 9:03 AM

Change 602296 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Add CI for labs/tools/ZppixBot

https://gerrit.wikimedia.org/r/602296

gerritbot added a comment.Jun 4 2020, 9:05 AM

Change 602296 merged by jenkins-bot:
[integration/config@master] Add CI for labs/tools/ZppixBot

https://gerrit.wikimedia.org/r/602296

gerritbot added a comment.Jun 4 2020, 9:20 AM

Change 602292 merged by jenkins-bot:
[labs/tools/ZppixBot@master] Add stylelint to lint the css file

https://gerrit.wikimedia.org/r/602292

gerritbot added a comment.Jun 4 2020, 9:22 AM

Change 602300 had a related patch set uploaded (by Hashar; owner: Hashar):
[labs/tools/ZppixBot@master] Add htmlllint to lint the HTML files

https://gerrit.wikimedia.org/r/602300

gerritbot added a comment.Jun 4 2020, 9:52 AM

Change 602300 merged by RhinosF1:
[labs/tools/ZppixBot@master] Add htmlllint to lint the HTML files

https://gerrit.wikimedia.org/r/602300

RhinosF1 assigned this task to hashar.Jun 4 2020, 9:54 AM
RhinosF1 set the point value for this task to 2.
RhinosF1 moved this task from To Triage / Backlog to 2020 June - September on the ZppixBot board.

html+css checks deployed and unsurprisingly failing - merged so we can fix in the re-design.

Maintenance_bot removed a project: Patch-For-Review.Jun 4 2020, 10:10 AM
gerritbot added a comment.Jun 4 2020, 10:11 AM

Change 602316 had a related patch set uploaded (by RhinosF1; owner: RhinosF1):
[labs/tools/ZppixBot@refs/meta/config] Switch to CI-Only submit access

https://gerrit.wikimedia.org/r/602316

gerritbot added a project: Patch-For-Review.Jun 4 2020, 10:11 AM
RhinosF1 moved this task from Backlog to In progress on the Continuous-Integration-Config board.Jun 4 2020, 10:16 AM
RhinosF1 added a project: User-RhinosF1.
RhinosF1 moved this task from Radar to Deployment on the User-RhinosF1 board.
RhinosF1 added a parent task: T233993: Improve & Update ZppixBot docs.Jun 4 2020, 10:21 AM
RhinosF1 added a comment.EditedJun 4 2020, 10:29 AM

I've done https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/1..2/.stylelintrc.json to stop it running on the upstream FA but my json is apparently invalid.

Once that's done and we've confirmed the checks are running fine, we can merge https://gerrit.wikimedia.org/r/602316 and resolve this.

RhinosF1 added a comment.Jun 4 2020, 11:43 AM
In T254393#6192145, @RhinosF1 wrote:

I've done https://gerrit.wikimedia.org/r/#/c/labs/tools/ZppixBot/+/602303/ to stop it running on the upstream FA but my json is apparently invalid.

Once that's done and we've confirmed the checks are running fine, we can merge https://gerrit.wikimedia.org/r/602316 and resolve this.

The tests are now running correctly, I will shortly turn off non-CI merges.

gerritbot added a comment.Jun 4 2020, 12:29 PM

Change 602316 merged by Hashar:
[labs/tools/ZppixBot@refs/meta/config] Switch to CI-Only push access

https://gerrit.wikimedia.org/r/602316

RhinosF1 closed this task as Resolved.Jun 4 2020, 12:30 PM
RhinosF1 removed a project: Patch-For-Review.
RhinosF1 moved this task from Deployment to Done on the User-RhinosF1 board.
hashar added a comment.Jun 4 2020, 9:26 PM

Well done @RhinosF1 ;)

RhinosF1 added a comment.Jun 4 2020, 9:27 PM
In T254393#6194426, @hashar wrote:

Well done @RhinosF1 ;)

You did the hard work, and @MacFan4000 managed to get them passing on the new site!

hashar added a comment.Jun 4 2020, 9:30 PM

Perfect! So from now on, you just have to Code-Review +2 and CI will take care of running the defined tests and ultimately get the change merged if everything is fine. Happy hacking!

RhinosF1 added a comment.Jun 4 2020, 9:32 PM
In T254393#6194453, @hashar wrote:

Perfect! So from now on, you just have to Code-Review +2 and CI will take care of running the defined tests and ultimately get the change merged if everything is fine. Happy hacking!

Same to you, Stay Safe!

hashar mentioned this in T257843: Enable CI on research/landing-page repo.Jul 29 2020, 7:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL