Make it possible to use <TAB> to select a user from the username suggestion list
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Jun 3 2020, 11:29 PM

Description

This task is about making it possible for people to use ⇥ to select a user from the username suggestion list.

Behavior

Visit: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Ppelberg-test#Not_working_for_me.
Click any "Reply" link in the section titled "Not working for me"
Open the Reply tool's visual mode
Type @
Observe the following usernames appear in the username suggestion list: ``
Use your mouse or arrow keys to focus on Ppelberg-test
Press ⇥

Actual behavior

❗️Notice the username suggestion list is dismissed and nothing is inserted into the reply text input.

Expected behavior

✅Notice @[[User:Ppelberg-test|Ppelberg-test]] is inserted into the reply text input.

Done

The "Expected behavior" is implemented [1]

Caveat: there may be a technical reason that prevents this from being implemented. If that's the case, please comment as much.

Related Objects
Search...

Status	Assigned	Task
Open	None	T253710 Make it more clear how to create an @ mention (you need to select an item from the suggestions list)
Resolved	Esanders	T254415 Make it possible to use <TAB> to select a user from the username suggestion list
Resolved	Esanders	T53229 Dropdown(Input)Widget/MenuSelectWidget: Tab key in dropdown boxes should pick the current selection (like Enter does)

Event Timeline

• ppelberg removed DLynch as the assignee of this task.Jun 3 2020, 11:29 PM

• ppelberg created this task.

I noticed this too last week and fixed it upstream in OOUI. Turns out it was a very old issue with dropdowns: T53229. The fix should be in the next OOUI release.

I've removed the large list of automatically added subscribers, presumably because this was created as a sub-task.

nice @Esanders

In T254415#6191030, @Esanders wrote:

I noticed this too last week and fixed it upstream in OOUI. Turns out it was a very old issue with dropdowns: T53229. The fix should be in the next OOUI release.

Oh, excellent. What should we do with this task then? My instinct: keep this task around to make QA more straight forward once 599038 lands.

• ppelberg moved this task from Needs Prioritization to Required after release on the OWC2020 (OWC2020 Replying 2.0) board.Jun 4 2020, 1:18 AM

We can make T53229 a subtask.

Yeah, that's best.

matmarex added a subtask: T53229: Dropdown(Input)Widget/MenuSelectWidget: Tab key in dropdown boxes should pick the current selection (like Enter does).Jun 4 2020, 11:37 AM

matmarex moved this task from Needs Discussion / Investigation to Blocked / Needs More Work on the Editing-team (Q3 2019-2020 Kanban Board) board.

matmarex subscribed.

Esanders renamed this task from Make it possible to use {key tab} to select a user from the username suggestion list to Make it possible to use <TAB> to select a user from the username suggestion list.Jun 4 2020, 1:57 PM

Esanders claimed this task.Jun 4 2020, 2:50 PM

(waiting for next OOUI release)

Volker_E closed subtask T53229: Dropdown(Input)Widget/MenuSelectWidget: Tab key in dropdown boxes should pick the current selection (like Enter does) as Resolved.Jun 4 2020, 11:03 PM

matmarex added a project: Editing QA.Jun 5 2020, 2:04 PM

matmarex moved this task from Blocked / Needs More Work to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

Ryasmeen edited projects, added Verified; removed Editing QA.Jun 5 2020, 8:42 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 5 2020, 8:53 PM

Nice.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 6 2020, 1:36 AM

AdHuikeshoven awarded a token.Jun 14 2020, 12:13 PM

AdHuikeshoven updated the task description. (Show Details)