Page MenuHomePhabricator

Newcomer tasks: choosing the suggestion in post-edit dialog should trigger guidance
Closed, ResolvedPublic

Description

After a newcomer receives the post-edit dialog with another suggested article, if they click on that suggestion, guidance should be triggered on their arrival. In the gif below, you can see that it does not happen in beta.

Event Timeline

Tgr claimed this task.Jun 5 2020, 8:48 AM

Another way to reproduce the problem is to click "Edit" (VE) and then click "Read"; the help panel and its call-to-action button disappear.

@Tgr my patch for guidance panel behavior (see https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/refs/changes/50/602050/3/modules/helppanel/ext.growthExperiments.HelpPanel.init.js#4) addresses this, although we can split that out into a separate patch for this one if you prefer

Change 602705 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Remove homepage pageview token verification

https://gerrit.wikimedia.org/r/602705

Change 602705 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Remove homepage pageview token verification

https://gerrit.wikimedia.org/r/602705

For @RHo and @MMiller_WMF review - no issues have been found.

Checked in`testwiki wmf.36` (but the fix was back-ported to wmf.35 too, so it can be seen with the hidden preference).
The animated gif shows how after the saved edit, a user can smoothly switch to another SE article for editing:

MMiller_WMF closed this task as Resolved.Jun 12 2020, 1:07 AM

This is working for me in production. Thank you!