Page MenuHomePhabricator
Create Task
Maniphest T254417

SpecialUserrights.php: Call to undefined method CentralAuthGroupMembershipProxy::canReceiveEmail()
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error message
[Xtg5GqwQBHcAAB1nC4kAAABP] /wiki/Special:GlobalUserRights/DannyS712 Error from line 716 of /srv/mediawiki/php-master/includes/specials/SpecialUserrights.php: Call to undefined method CentralAuthGroupMembershipProxy::canReceiveEmail()
Stack Trace
Backtrace:

#0 /srv/mediawiki/php-master/includes/specials/SpecialUserrights.php(506): UserrightsPage->showEditUserGroupsForm(CentralAuthGroupMembershipProxy, array, array)
#1 /srv/mediawiki/php-master/includes/specials/SpecialUserrights.php(227): UserrightsPage->editUserGroupsForm(string)
#2 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(580): UserrightsPage->execute(string)
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(634): SpecialPage->run(string)
#4 /srv/mediawiki/php-master/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(986): MediaWiki->performRequest()
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(543): MediaWiki->main()
#7 /srv/mediawiki/php-master/index.php(47): MediaWiki->run()
#8 /srv/mediawiki/w/index.php(3): require(string)
#9 {main}
Impact

Unable to use Special:GlobalUserRights

Notes

Caused by T251534: Special:UserRights shows "send email" for user without valid email
Stack trace is for beta cluster, but also exists in production - error code 71202776-036d-43b1-8e99-dce1c5a2fe72

Details

Request ID
Xtg5GqwQBHcAAB1nC4kAAABP
Request URL
https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:GlobalUserRights/DannyS712
Stack Trace

Backtrace:

#0 /srv/mediawiki/php-master/includes/specials/SpecialUserrights.php(506): UserrightsPage->showEditUserGroupsForm(CentralAuthGroupMembershipProxy, array, array)
#1 /srv/mediawiki/php-master/includes/specials/SpecialUserrights.php(227): UserrightsPage->editUserGroupsForm(string)
#2 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(580): UserrightsPage->execute(string)
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(634): SpecialPage->run(string)
#4 /srv/mediawiki/php-master/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#5 /srv/mediawiki/php-master/includes/MediaWiki.php(986): MediaWiki->performRequest()
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(543): MediaWiki->main()
#7 /srv/mediawiki/php-master/index.php(47): MediaWiki->run()
#8 /srv/mediawiki/w/index.php(3): require(string)
#9 {main}

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Don't show email link if the user cannot be emailed."mediawiki/coremaster+2 -2
Revert "Don't show email link if the user cannot be emailed."mediawiki/corewmf/1.35.0-wmf.35+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Jun 4 2020, 12:00 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 4 2020, 12:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 claimed this task.Jun 4 2020, 12:02 AM
DannyS712 triaged this task as Unbreak Now! priority.
DannyS712 added projects: MediaWiki-Special-pages, MediaWiki-User-management.
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 4 2020, 12:02 AM
gerritbot added a comment.Jun 4 2020, 12:02 AM

Change 602196 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Revert "Don't show email link if the user cannot be emailed."

https://gerrit.wikimedia.org/r/602196

gerritbot added a project: Patch-For-Review.Jun 4 2020, 12:02 AM
DannyS712 added a project: Beta-Cluster-reproducible.Jun 4 2020, 12:07 AM
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Jun 4 2020, 12:08 AM

Change 602198 had a related patch set uploaded (by Reedy; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.35] Revert "Don't show email link if the user cannot be emailed."

https://gerrit.wikimedia.org/r/602198

gerritbot added a comment.Jun 4 2020, 12:21 AM

Change 602196 merged by jenkins-bot:
[mediawiki/core@master] Revert "Don't show email link if the user cannot be emailed."

https://gerrit.wikimedia.org/r/602196

gerritbot added a comment.Jun 4 2020, 12:26 AM

Change 602198 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.35] Revert "Don't show email link if the user cannot be emailed."

https://gerrit.wikimedia.org/r/602198

• Agusbou2015 subscribed.Jun 4 2020, 12:27 AM
DannyS712 removed a project: Patch-For-Review.Jun 4 2020, 12:33 AM
DannyS712 moved this task from Untriaged to Jun 2020 on the Wikimedia-production-error board.
Stashbot mentioned this in T251534: Special:UserRights shows "send email" for user without valid email.Jun 4 2020, 12:36 AM

Mentioned in SAL (#wikimedia-operations) [2020-06-04T00:36:01Z] <reedy@deploy1001> Synchronized php-1.35.0-wmf.35/includes/specials/SpecialUserrights.php: T254417 T251534 (duration: 01m 06s)

Reedy closed this task as Resolved.Jun 4 2020, 12:36 AM
DannyS712 added a comment.Jun 4 2020, 12:36 AM

Confirmed to work again - https://www.mediawiki.org/wiki/Special:GlobalUserRights/DannyS712, https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:GlobalUserRights/DannyS712

DannyS712 mentioned this in T232568: Special:UserRights exposes the existence of hidden users (CVE-2020-25813).Jul 4 2020, 2:17 PM
DannyS712 moved this task from Unsorted to Merged on the User-DannyS712 board.Jul 9 2020, 11:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits