Add support for language/toolbox SidebarBeforeOutput hook to Timeless
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 4 2020, 12:50 AM

Description

Following examples of https://gerrit.wikimedia.org/r/c/601089 and https://gerrit.wikimedia.org/r/c/601095 and https://gerrit.wikimedia.org/r/c/601176 in Cologne blue, Modern and Monobook (and Vector) let's make sure Timeless allows display of toolbox and language menu alterations in the skin.

Acceptance criteria

Make sure language_urls is no longer used - and getLanguages or sidebar['LANGUAGES"] is used instead.
Don't call TimelessTemplate::getToolbox - instead pass sidebar['TOOLBOX'] into getPageTools
Make sure when getAfterPortlet is non-empty, display is overriden.

Details

	Subject	Repo	Branch	Lines +/-
	Timeless: support SidebarBeforeOutput hook	mediawiki/skins/Timeless	master	+26 -11

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Ammarpad	T253809 [EPIC] Deprecate the BaseTemplate hooks
Resolved	Ammarpad	T253783 [EPIC] Deprecate SkinTemplateToolboxEnd hook in favor of SidebarBeforeOutput hook
Resolved	Ammarpad	T254419 Add support for language/toolbox SidebarBeforeOutput hook to Timeless

Event Timeline

Jdlrobson created this task.Jun 4 2020, 12:50 AM

Jdlrobson edited projects, added Timeless; removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).

Jdlrobson mentioned this in T253783: [EPIC] Deprecate SkinTemplateToolboxEnd hook in favor of SidebarBeforeOutput hook.

I'm working on it :)

Jdlrobson awarded a token.Jun 4 2020, 2:08 PM

Change 602458 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Timeless@master] Timeless: support SidebarBeforeOutput hook

https://gerrit.wikimedia.org/r/602458

gerritbot added a project: Patch-For-Review.Jun 4 2020, 6:49 PM

Jdlrobson moved this task from Backlog to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.Jun 5 2020, 8:38 PM

Jdlrobson triaged this task as Medium priority.Jun 5 2020, 8:52 PM

Jdlrobson updated the task description. (Show Details)

Change 602458 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Timeless: support SidebarBeforeOutput hook

https://gerrit.wikimedia.org/r/602458

Jdlrobson closed this task as Resolved.Jun 10 2020, 8:34 PM

Jdlrobson updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 10 2020, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2020, 9:11 PM