Page MenuHomePhabricator

ComboBoxInputWidget (filtering on input): when item is selected, menu button doesn't trigger menu
Closed, ResolvedPublic

Description

'ComboBoxInputWidget (filtering on input)' currently as of v0.39.0, when a menu item is selected, I can't trigger the autocomplete menu any more.

It's not clear to the user if that's a result of a value input, if user inputs custom value, it still triggers autocomplete menu.

Surfaced while looking into https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/599038/, but unrelated.

Event Timeline

Volker_E created this task.Jun 4 2020, 4:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2020, 4:35 AM

I think this is a problem with the specific example we have in our demo, and not the implementation.

The filtering is done by matching the input against the labels of the menu options, while selecting an option inserts the data of the menu option into the input. It turns out that the data of each option doesn't match its label, so if you put it into the input, all of the options are filtered out. I think this behavior is correct, and we should make a better demo.

Change 602436 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] demos: Use more practical options for 'ComboBoxInputWidget (filtering on input)'

https://gerrit.wikimedia.org/r/602436

Change 602436 merged by jenkins-bot:
[oojs/ui@master] demos: Use more practical options for 'ComboBoxInputWidget (filtering on input)'

https://gerrit.wikimedia.org/r/602436

Change 602503 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.39.1

https://gerrit.wikimedia.org/r/602503

Change 602503 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.39.1

https://gerrit.wikimedia.org/r/602503

Volker_E closed this task as Resolved.Jun 4 2020, 11:01 PM
Volker_E assigned this task to matmarex.
Volker_E triaged this task as Low priority.
Volker_E moved this task from Backlog to OOUI-0.39.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.39.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.