Job mediawiki_job_cirrus_build_completion_indices should not ignore failures
Open, HighPublic
Actions

Assigned To

None

Authored By

	dcausse
	Jun 4 2020, 8:27 AM

Description

cirrus_build_completion_indices.sh should not ignore failures of the underlying script extensions/CirrusSearch/maintenance/UpdateSuggesterIndex.php.

Prior to adding | ts '{}' it was failing with a 123 status probably because of wikidata: Completion suggester disabled, quitting... for wikidata.
Since we expect this error UpdateSuggesterIndex could perhaps return a success in this case.

To sum-up this task is:

make sure cirrus_build_completion_indices.sh in puppet reports a failure when UpdateSuggesterIndex.php fails
make sure that UpdateSuggesterIndex.php does not return with an error when quitting with this message: Completion suggester disabled, quitting...

Event Timeline

dcausse created this task.Jun 4 2020, 8:27 AM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptJun 4 2020, 8:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

dcausse updated the task description. (Show Details)Jun 4 2020, 8:28 AM

dcausse updated the task description. (Show Details)Jun 4 2020, 8:35 AM

dcausse added a subscriber: RKemper.

Note that mediawiki_job_cirrus_build_completion_indices_eqiad is also affected.

Indeed.
Acking the alert https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=mwmaint1002&service=Check+systemd+state with that task.

Dzahn renamed this task from Job mediawiki_job_cirrus_build_completion_indices_codfw fails to Job mediawiki_job_cirrus_build_completion_indices fails.Jun 5 2020, 8:00 AM

dcausse updated the task description. (Show Details)Jun 5 2020, 8:48 AM

ayounsi unsubscribed.Jun 5 2020, 8:58 AM

Adding | ts '{}' seemed to have hidden the failure related to this feature not being enabled for wikidata.
It'd be nice to not ignore, re-purposing this ticket accordingly.

dcausse renamed this task from Job mediawiki_job_cirrus_build_completion_indices fails to Job mediawiki_job_cirrus_build_completion_indices should not ignore failures.Jun 22 2020, 7:18 AM

dcausse updated the task description. (Show Details)

Getting away from bash and rewriting this in python might be a good idea.

Gehel raised the priority of this task from Medium to High.Sep 1 2020, 7:09 PM

Job mediawiki_job_cirrus_build_completion_indices should not ignore failuresOpen, HighPublicActions

Description

Event Timeline

Job mediawiki_job_cirrus_build_completion_indices should not ignore failures
Open, HighPublic
Actions