Page MenuHomePhabricator

Newcomer tasks: UI fixes to Suggested edit guidance screen - Quick start tips
Closed, ResolvedPublic

Assigned To
Authored By
RHo
Jun 4 2020, 10:04 PM
Referenced Files
F31946971: image.png
Jul 24 2020, 2:50 PM
F31946973: image.png
Jul 24 2020, 2:50 PM
F31946963: image.png
Jul 24 2020, 2:50 PM
F31946967: image.png
Jul 24 2020, 2:50 PM
F31946401: Screen Shot 2020-07-23 at 4.54.29 PM.png
Jul 23 2020, 11:57 PM
F31946397: Screen Shot 2020-07-23 at 4.53.34 PM.png
Jul 23 2020, 11:57 PM
F31946405: Screen Shot 2020-07-23 at 4.47.48 PM.png
Jul 23 2020, 11:57 PM
F31946384: Screen Shot 2020-07-23 at 4.39.41 PM.png
Jul 23 2020, 11:57 PM

Description

This task tracks design fixes on the panel header of the suggested edits screen which were found on both Desktop and Mobile versions.

Actual (CS Betalabs 04-Jun) DesktopExpected (Zeplin mock)
image.png (784×722 px, 136 KB)
image.png (600×408 px, 36 KB)

There are some alignment and padding issues:
i. There should be 24px spacing between the top of “Quick start tips” heading text and the bottom of the panel header. Potentially fixed by adding .suggested-edits-panel-header {margin-bottom:16px;}

Actual
image.png (354×628 px, 37 KB)
Expected
image.png (130×350 px, 6 KB)

ii. There should be 16px top padding (not 8px) between the tabs divider and the tip text

Actual
image.png (176×688 px, 24 KB)
Expected
image.png (250×786 px, 72 KB)

iii. There should be only 12px padding all around the supplement example text and its container
Currently, there is too much top and bottom padding in the example text, possibly due to double padding

Actual
image.png (456×1 px, 216 KB)
Expected
image.png (158×1 px, 25 KB)

iv. Inline icons in guidance text should have 8px left and right padding

Actual
image.png (178×430 px, 29 KB)
Expected
image.png (186×352 px, 10 KB)

v. There should be 16px spacing expected between each guidance content element

Actual
image.png (598×1 px, 202 KB)
Expected
image.png (888×822 px, 73 KB)

Event Timeline

Change 605587 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help panel UI fixes

https://gerrit.wikimedia.org/r/605587

Tgr subscribed.

The patch takes care of points ii-v, but not i as far as I can see.

Change 605587 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel UI fixes

https://gerrit.wikimedia.org/r/605587

The patch takes care of points ii-v, but not i as far as I can see.

Hmph, must have been lost in a rebase.

Change 606500 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help panel: Adjust margin on suggested edits panel

https://gerrit.wikimedia.org/r/606500

Change 606500 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: Adjust padding on quick start tips header

https://gerrit.wikimedia.org/r/606500

Some of the fixes have been deployed, hence there is no comparison pictures.

i. There should be 24px spacing between the top of “Quick start tips” heading text and the bottom of the panel header. Potentially fixed by adding .suggested-edits-panel-header {margin-bottom:16px;}

before the fixafter the fix
Screen Shot 2020-07-23 at 3.17.15 PM.png (665×393 px, 90 KB)
Screen Shot 2020-07-23 at 3.12.07 PM.png (668×428 px, 96 KB)
Screen Shot 2020-07-23 at 3.08.24 PM.png (635×427 px, 87 KB)
Screen Shot 2020-07-23 at 3.12.19 PM.png (537×369 px, 41 KB)

ii. There should be 16px top padding (not 8px) between the tabs divider and the tip text

Screen Shot 2020-07-23 at 3.33.54 PM.png (534×368 px, 50 KB)
Screen Shot 2020-07-23 at 3.23.29 PM.png (540×362 px, 44 KB)

iii. There should be only 12px padding all around the supplement example text and its container
Currently, there is too much top and bottom padding in the example text, possibly due to double padding

Screen Shot 2020-07-23 at 4.32.55 PM.png (564×379 px, 48 KB)

iv. Inline icons in guidance text should have 8px left and right padding

Screen Shot 2020-07-23 at 4.39.41 PM.png (425×414 px, 44 KB)

v. There should be 16px spacing expected between each guidance content element

It seems to be in place.

Screen Shot 2020-07-23 at 4.54.29 PM.png (482×373 px, 52 KB)
Screen Shot 2020-07-23 at 4.53.34 PM.png (544×371 px, 64 KB)

Note: The placement of text and icons looks a bit tight - please advise whether some adjustments are needed here:

Screen Shot 2020-07-23 at 4.47.48 PM.png (546×369 px, 62 KB)

Note: The placement of text and icons looks a bit tight - please advise whether some adjustments are needed here:

Screen Shot 2020-07-23 at 4.47.48 PM.png (546×369 px, 62 KB)

Thanks for noticing that @Etonkovidova, this is because the guidance text is setup so icons are shown inline within the paragraph here so it can look strange if adding top and bottom padding/margins. Maybe we should could look at adding a <br> before and after the icons in this instance instead on the translatewiki field?

image.png (696×734 px, 86 KB)
image.png (250×708 px, 28 KB)

LGTM too on Desktop and Mobile for the points in the task though so will move to PM review.

Desktop
image.png (1×792 px, 107 KB)
Mobile
image.png (1×722 px, 100 KB)