[BUG] Newcomer tasks: Suggested edit footer text displaying poorly when text overflows single line
Closed, ResolvedPublicBUG REPORT
Actions

Description

This can be seen on cswiki when the panel is at its narrowest. The footer copy overlaps when it goes over a single line.

Proposed fix

This involves:

Allowing footer height to adjust to fit content
Update the line-height from .mw-ge-help-panel-processdialog .suggested-edits-panel-footer-text {line-height:0.65} to a line-height:1.3;

Notes:
@Catrope has advised there may be knock on effects on the panel scrolling behavior if the footer is height is changed from a fixed number to "fit-content".
Maybe doable by using flexbox and setting a min-height, but in the interim we may wish to allow ellipsis for when footer text is over one line.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/GrowthExperiments	master	+5 -11	Suggested edits: use flexbox instead of fixed height for footer

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T239181 [EPIC] Growth: Newcomer tasks 1.2 (guidance)
Resolved		kostajh	T244431 Newcomer tasks: guidance panel behavior
Resolved		kostajh	T244541 Newcomer tasks: suggested edit screen in guidance
Resolved	BUG REPORT	Catrope	T254532 [BUG] Newcomer tasks: Suggested edit footer text displaying poorly when text overflows single line

Event Timeline

RHo created this task.Jun 4 2020, 10:46 PM

Restricted Application changed the subtype of this task from "Task" to "Bug Report". · View Herald TranscriptJun 4 2020, 10:46 PM

RHo moved this task from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.Jun 4 2020, 10:47 PM

Catrope claimed this task.Jun 8 2020, 5:13 PM

Catrope moved this task from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.

Change 603553 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Suggested edits: use flexbox instead of fixed height for footer

https://gerrit.wikimedia.org/r/603553

gerritbot added a project: Patch-For-Review.Jun 8 2020, 5:29 PM

Catrope moved this task from In Progress to Code Review on the Growth-Team (Current Sprint) board.Jun 8 2020, 5:29 PM

Unrelated to this task, but I noticed the footer is not hidden when switching to edit mode on mobile.

Change 603553 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested edits: use flexbox instead of fixed height for footer

https://gerrit.wikimedia.org/r/603553

Tgr moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Jun 9 2020, 12:04 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 12:10 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 9 2020, 1:00 AM

In T254532#6204333, @Tgr wrote:

Unrelated to this task, but I noticed the footer is not hidden when switching to edit mode on mobile.

@Etonkovidova -- could you please check and file this?

In T254532#6204482, @MMiller_WMF wrote:

In T254532#6204333, @Tgr wrote:

Unrelated to this task, but I noticed the footer is not hidden when switching to edit mode on mobile.

@Etonkovidova -- could you please check and file this?

That's because we set edit mode only when the help panel is open, but on mobile it's closed when the user taps Edit. I've added this into the overall patch for guidance behavior rules https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/602050

For Design review - no issues were found.

Checked in betalabs - on both mobile and desktop (with a narrow panel, just in case) - the fix is in place:
(on the screenshots some UI bugs are present - the difficulty level label is displayed on two lines, double vertical scrolling and a narrow panel have been reported in other phab tasks).