This is happening on it.wiki regardless of users preferences and as far as I can tell is probably caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/598137/
Description
Description
Details
Details
Customize query in gerrit
Event Timeline
Comment Actions
This is a serious bug and slows down work on wikis, please fix it urgently. Now that piece of code isn’t reading the user preferences and asking always rollback confirmation, so I’d like to kindly ask you to fix it, thanking you in advance.
Comment Actions
@Ferdi2005: Please see and follow https://www.mediawiki.org/wiki/Bug_management/Phabricator_etiquette to avoid phrases like "you aren't caring". Thanks!
Comment Actions
Fixed @Aklapper, sorry, but I think that I wrote badly a sentence to tell you about the bug, I’d rather mean that the piece of code isn’t reading the user preference. I fixed it anyway
Comment Actions
Hello! This is happening on pt.wiki too. I just tested it. The rollback button requires confirmation even when set not to do it on preferences. When the revision is marked as patrolled, confirmation is not requested and the revision is promptly reverted.
Comment Actions
Change 603520 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Revert "resources: Bundle ajax patrol and ajax rollback code"
Comment Actions
Change 603520 abandoned by Urbanecm:
Revert "resources: Bundle ajax patrol and ajax rollback code"
Reason:
okay, thanks Krinkle
Comment Actions
Change 603536 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.misc-authed-curate: Check for 'showrollbackconfirmation' preference
Comment Actions
Change 603544 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@wmf/1.35.0-wmf.35] mediawiki.misc-authed-curate: Check for 'showrollbackconfirmation' preference
Comment Actions
Change 603536 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.misc-authed-curate: Check for 'showrollbackconfirmation' preference
Comment Actions
Change 603544 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.35] mediawiki.misc-authed-curate: Check for 'showrollbackconfirmation' preference
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2020-06-08T17:43:16Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.35/resources/src/mediawiki.misc-authed-curate/rollback.js: Fix: Diff pages show rollback confirmation prompt if there is the "Mark as patrolled" link (T254538) (duration: 00m 59s)