Page MenuHomePhabricator
Create Task
Maniphest T254542

Replace uses of deprecated User and Title methods with WatchlistNotificationManager
Closed, ResolvedPublic
Actions

Description

Follow-up to T208777: Factor notification-related methods out of User and Title, introduce WatchlistNotificationManager

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Echomaster+0 -0Remove use of Title::getNotificationTimestamp
mediawiki/coremaster+4 -1Use WatchlistNotificationManager in SpecialWatchlist
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jun 5 2020, 2:34 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 5 2020, 2:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 mentioned this in T208777: Factor notification-related methods out of User and Title, introduce WatchlistNotificationManager.Jun 5 2020, 2:34 AM
gerritbot added a comment.Jun 5 2020, 2:36 AM

Change 602547 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject WatchlistNotificationManager into SpecialWatchlist

https://gerrit.wikimedia.org/r/602547

gerritbot added a project: Patch-For-Review.Jun 5 2020, 2:36 AM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Jun 5 2020, 2:38 AM
gerritbot added a comment.Jun 5 2020, 4:54 PM

Change 602547 merged by jenkins-bot:
[mediawiki/core@master] Use WatchlistNotificationManager in SpecialWatchlist

https://gerrit.wikimedia.org/r/602547

DannyS712 removed a project: Patch-For-Review.Jun 5 2020, 4:56 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 5 2020, 5:00 PM
gerritbot added a comment.Jun 8 2020, 1:38 AM

Change 603067 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Remove use of Title::getNotificationTimestamp

https://gerrit.wikimedia.org/r/603067

gerritbot added a project: Patch-For-Review.Jun 8 2020, 1:38 AM

Change 603067 abandoned by DannyS712:
Remove use of Title::getNotificationTimestamp

Reason:
Uses WatchedItem method, not Title

https://gerrit.wikimedia.org/r/603067

DannyS712 removed a project: Patch-For-Review.Jun 8 2020, 1:39 AM
CCicalese_WMF removed a project: Platform Team Workboards (External Code Reviews).Aug 11 2020, 8:38 PM
CCicalese_WMF added a subscriber: CCicalese_WMF.

Untagging, since there is nothing to review right now. Feel free to re-tag if there's a new patch.

DannyS712 removed DannyS712 as the assignee of this task.Aug 11 2020, 8:50 PM

Unlicking - may work on this at some point, but until then patches from others are welcome

Daimona added a subscriber: Daimona.Feb 12 2022, 3:08 PM

Codesearch seems clean at this point. Anything left to do here?

Umherirrender closed this task as Resolved.Sat, Jun 25, 6:57 PM
Umherirrender added a project: Technical-Debt (Deprecation process).
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL