Page MenuHomePhabricator
Create Task
Maniphest T254548

Regression: Tool "User uploads" in the sidebar missing in skin Monobook
Closed, ResolvedPublic
Actions

Description

The tool "User uploads" in the sidebar missing in skin Monobook (at least) since the last deployment train. In Vector the link is still there.

Steps to reproduce :

Details

SubjectRepoBranchLines +/-
UploadsLink: Use SidebarBeforeOutput hook to add toolbox itemmediawiki/extensions/UploadsLinkmaster+18 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

Raymond created this task.Jun 5 2020, 6:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2020, 6:10 AM
Ammarpad claimed this task.Jun 5 2020, 7:00 AM
Ammarpad triaged this task as Medium priority.
Ammarpad removed a project: Platform Engineering.
Ammarpad added a project: MediaWiki-extensions-UploadsLink.
Ammarpad added a parent task: T253416: Deprecate BaseTemplateToolbox hook.Jun 5 2020, 8:14 AM
gerritbot added a comment.Jun 5 2020, 8:15 AM

Change 602612 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/UploadsLink@master] UploadsLink: Use SidebarBeforeOutput hook to add toolbox item

https://gerrit.wikimedia.org/r/602612

gerritbot added a project: Patch-For-Review.Jun 5 2020, 8:15 AM
Wurgl subscribed.Jun 5 2020, 10:28 AM

Maybe related: Link to Wikidata-Object is missing too (only in MonoBook, all other skins I tried show that link)

Jdlrobson renamed this task from Tool "User uploads" in the sidebar missing in skin Monobook to Regression: Tool "User uploads" in the sidebar missing in skin Monobook.Jun 5 2020, 4:12 PM
gerritbot added a comment.Jun 5 2020, 4:14 PM

Change 602612 merged by jenkins-bot:
[mediawiki/extensions/UploadsLink@master] UploadsLink: Use SidebarBeforeOutput hook to add toolbox item

https://gerrit.wikimedia.org/r/602612

Jdlrobson closed this task as Resolved.Jun 5 2020, 4:22 PM
Jdlrobson subscribed.

Hey @Raymond this should be fixed in the next train. Sorry about that. We're making some technical changes to simplify the menu code and sadly I missed this one in code review.

The fix for this will roll out in next week's train but the patch can be SWATTed to 1.35.0-wmf.35 if it's needed sooner (https://wikitech.wikimedia.org/wiki/Deployments)

Ammarpad mentioned this in rEULK338d47ba1548: UploadsLink: Use SidebarBeforeOutput hook to add toolbox item.Jun 5 2020, 4:23 PM
Jdlrobson added a comment.Jun 5 2020, 4:27 PM
In T254548#6195703, @Wurgl wrote:

Maybe related: Link to Wikidata-Object is missing too (only in MonoBook, all other skins I tried show that link)

Have captured this in T254485

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 5 2020, 5:00 PM
Raymond added a comment.Jun 5 2020, 5:02 PM
In T254548#6197069, @Jdlrobson wrote:

Hey @Raymond this should be fixed in the next train. Sorry about that. We're making some technical changes to simplify the menu code and sadly I missed this one in code review.

The fix for this will roll out in next week's train but the patch can be SWATTed to 1.35.0-wmf.35 if it's needed sooner (https://wikitech.wikimedia.org/wiki/Deployments)

Thank you, @Jdlrobson. I think deployment with the next train is fine.

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2020, 5:10 PM
Jdlrobson added a comment.Jun 5 2020, 5:11 PM

Thanks for flagging it. Please do let me know if you see anything else strange in menus over the course of this month after which we should be back to a place of stability :)

bjh21 mentioned this in T255444: Regression: Sidebar "User uploads" link now missing from Commons user pages.Jun 15 2020, 2:10 PM
Jdlrobson added a comment.Jun 16 2020, 12:11 AM

Strangely this is still not working

I'm also not seeing this link on the beta cluster:
https://commons.wikimedia.beta.wmflabs.org/wiki/User:Selenium_user
We'll continue exploring in T255444 as this now impacts Vector AND Monobook

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL