Page MenuHomePhabricator
Create Task
Maniphest T254558

Update Nuke hook running to use HookContainer
Closed, ResolvedPublic
Actions

Description

Nuke requires 1.35+, so the new hook systems are alway available

Details

SubjectRepoBranchLines +/-
Update hook calling to use new HookContainer systemmediawiki/extensions/Nukemaster+112 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Jun 5 2020, 9:39 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 5 2020, 9:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jun 5 2020, 9:39 AM

Change 602627 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Nuke@master] Update hook calling to use new HookContainer system

https://gerrit.wikimedia.org/r/602627

gerritbot added a project: Patch-For-Review.Jun 5 2020, 9:39 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jun 5 2020, 9:49 AM
DannyS712 added a project: Platform Engineering.

Tagging CPT for review since the new hook system is a CPT initiative

• Pchelolo edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Jun 5 2020, 9:22 PM
DannyS712 added a parent task: T254670: [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system.Jun 6 2020, 9:17 PM
gerritbot added a comment.Jul 3 2020, 3:13 AM

Change 602627 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Update hook calling to use new HookContainer system

https://gerrit.wikimedia.org/r/602627

DannyS712 closed this task as Resolved.Jul 3 2020, 3:20 AM
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 3 2020, 4:00 AM
DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Jul 9 2020, 11:14 PM
Jdforrester-WMF edited parent tasks, added: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system; removed: T254670: [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system.Sep 20 2020, 1:00 PM
dang mentioned this in T290850: Fix deprecated \Hooks::run call in \Wikibase\Client\includes\Changes\ChangeHandler.Oct 8 2021, 1:07 PM
Umherirrender mentioned this in T338450: Update StructuredDiscussions (Flow) to use the new HookContainer/HookRunner system.Sep 16 2023, 10:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL